841 lines
23 KiB
Go
841 lines
23 KiB
Go
package brotli
|
|
|
|
import (
|
|
"bytes"
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/andybalholm/brotli"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
var (
|
|
smallTestBody = []byte("aaabbc" + strings.Repeat("aaabbbccc", 9) + "aaabbbc")
|
|
bigTestBody = []byte(strings.Repeat(strings.Repeat("aaabbbccc", 66)+" ", 6) + strings.Repeat("aaabbbccc", 66))
|
|
)
|
|
|
|
func Test_Vary(t *testing.T) {
|
|
h := newTestHandler(t, smallTestBody)
|
|
|
|
req, _ := http.NewRequest(http.MethodGet, "/whatever", nil)
|
|
req.Header.Set(acceptEncoding, "br")
|
|
|
|
rw := httptest.NewRecorder()
|
|
h.ServeHTTP(rw, req)
|
|
|
|
assert.Equal(t, http.StatusOK, rw.Code)
|
|
assert.Equal(t, acceptEncoding, rw.Header().Get(vary))
|
|
}
|
|
|
|
func Test_SmallBodyNoCompression(t *testing.T) {
|
|
h := newTestHandler(t, smallTestBody)
|
|
|
|
req, _ := http.NewRequest(http.MethodGet, "/whatever", nil)
|
|
req.Header.Set(acceptEncoding, "br")
|
|
|
|
rw := httptest.NewRecorder()
|
|
h.ServeHTTP(rw, req)
|
|
|
|
// With less than 1024 bytes the response should not be compressed.
|
|
assert.Equal(t, http.StatusOK, rw.Code)
|
|
assert.Empty(t, rw.Header().Get(contentEncoding))
|
|
assert.Equal(t, smallTestBody, rw.Body.Bytes())
|
|
}
|
|
|
|
func Test_AlreadyCompressed(t *testing.T) {
|
|
h := newTestHandler(t, bigTestBody)
|
|
|
|
req, _ := http.NewRequest(http.MethodGet, "/compressed", nil)
|
|
req.Header.Set(acceptEncoding, "br")
|
|
|
|
rw := httptest.NewRecorder()
|
|
h.ServeHTTP(rw, req)
|
|
|
|
assert.Equal(t, bigTestBody, rw.Body.Bytes())
|
|
}
|
|
|
|
func Test_NoBody(t *testing.T) {
|
|
testCases := []struct {
|
|
desc string
|
|
statusCode int
|
|
body []byte
|
|
}{
|
|
{
|
|
desc: "status no content",
|
|
statusCode: http.StatusNoContent,
|
|
body: nil,
|
|
},
|
|
{
|
|
desc: "status not modified",
|
|
statusCode: http.StatusNotModified,
|
|
body: nil,
|
|
},
|
|
{
|
|
desc: "status OK with empty body",
|
|
statusCode: http.StatusOK,
|
|
body: []byte{},
|
|
},
|
|
{
|
|
desc: "status OK with nil body",
|
|
statusCode: http.StatusOK,
|
|
body: nil,
|
|
},
|
|
}
|
|
|
|
for _, test := range testCases {
|
|
test := test
|
|
t.Run(test.desc, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
h := mustNewWrapper(t, Config{MinSize: 1024})(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
|
|
rw.WriteHeader(test.statusCode)
|
|
|
|
_, err := rw.Write(test.body)
|
|
require.NoError(t, err)
|
|
}))
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/", nil)
|
|
req.Header.Set(acceptEncoding, "br")
|
|
|
|
rw := httptest.NewRecorder()
|
|
h.ServeHTTP(rw, req)
|
|
|
|
body, err := io.ReadAll(rw.Body)
|
|
require.NoError(t, err)
|
|
|
|
assert.Empty(t, rw.Header().Get(contentEncoding))
|
|
assert.Empty(t, body)
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_MinSize(t *testing.T) {
|
|
cfg := Config{
|
|
MinSize: 128,
|
|
}
|
|
|
|
var bodySize int
|
|
h := mustNewWrapper(t, cfg)(http.HandlerFunc(
|
|
func(rw http.ResponseWriter, req *http.Request) {
|
|
for i := 0; i < bodySize; i++ {
|
|
// We make sure to Write at least once less than minSize so that both
|
|
// cases below go through the same algo: i.e. they start buffering
|
|
// because they haven't reached minSize.
|
|
_, err := rw.Write([]byte{'x'})
|
|
require.NoError(t, err)
|
|
}
|
|
},
|
|
))
|
|
|
|
req, _ := http.NewRequest(http.MethodGet, "/whatever", &bytes.Buffer{})
|
|
req.Header.Add(acceptEncoding, "br")
|
|
|
|
// Short response is not compressed
|
|
bodySize = cfg.MinSize - 1
|
|
rw := httptest.NewRecorder()
|
|
h.ServeHTTP(rw, req)
|
|
|
|
assert.Empty(t, rw.Result().Header.Get(contentEncoding))
|
|
|
|
// Long response is compressed
|
|
bodySize = cfg.MinSize
|
|
rw = httptest.NewRecorder()
|
|
h.ServeHTTP(rw, req)
|
|
|
|
assert.Equal(t, "br", rw.Result().Header.Get(contentEncoding))
|
|
}
|
|
|
|
func Test_MultipleWriteHeader(t *testing.T) {
|
|
h := mustNewWrapper(t, Config{MinSize: 1024})(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
|
|
// We ensure that the subsequent call to WriteHeader is a noop.
|
|
rw.WriteHeader(http.StatusInternalServerError)
|
|
rw.WriteHeader(http.StatusNotFound)
|
|
}))
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/", nil)
|
|
req.Header.Set(acceptEncoding, "br")
|
|
|
|
rw := httptest.NewRecorder()
|
|
h.ServeHTTP(rw, req)
|
|
|
|
assert.Equal(t, http.StatusInternalServerError, rw.Code)
|
|
}
|
|
|
|
func Test_FlushBeforeWrite(t *testing.T) {
|
|
srv := httptest.NewServer(mustNewWrapper(t, Config{MinSize: 1024})(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
|
|
rw.WriteHeader(http.StatusOK)
|
|
rw.(http.Flusher).Flush()
|
|
|
|
_, err := rw.Write(bigTestBody)
|
|
require.NoError(t, err)
|
|
})))
|
|
defer srv.Close()
|
|
|
|
req, err := http.NewRequest(http.MethodGet, srv.URL, http.NoBody)
|
|
require.NoError(t, err)
|
|
|
|
req.Header.Set(acceptEncoding, "br")
|
|
|
|
res, err := http.DefaultClient.Do(req)
|
|
require.NoError(t, err)
|
|
|
|
defer res.Body.Close()
|
|
|
|
assert.Equal(t, http.StatusOK, res.StatusCode)
|
|
assert.Equal(t, "br", res.Header.Get(contentEncoding))
|
|
|
|
got, err := io.ReadAll(brotli.NewReader(res.Body))
|
|
require.NoError(t, err)
|
|
assert.Equal(t, bigTestBody, got)
|
|
}
|
|
|
|
func Test_FlushAfterWrite(t *testing.T) {
|
|
srv := httptest.NewServer(mustNewWrapper(t, Config{MinSize: 1024})(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
|
|
rw.WriteHeader(http.StatusOK)
|
|
|
|
_, err := rw.Write(bigTestBody[0:1])
|
|
require.NoError(t, err)
|
|
|
|
rw.(http.Flusher).Flush()
|
|
for _, b := range bigTestBody[1:] {
|
|
_, err := rw.Write([]byte{b})
|
|
require.NoError(t, err)
|
|
}
|
|
})))
|
|
defer srv.Close()
|
|
|
|
req, err := http.NewRequest(http.MethodGet, srv.URL, http.NoBody)
|
|
require.NoError(t, err)
|
|
|
|
req.Header.Set(acceptEncoding, "br")
|
|
|
|
res, err := http.DefaultClient.Do(req)
|
|
require.NoError(t, err)
|
|
|
|
defer res.Body.Close()
|
|
|
|
assert.Equal(t, http.StatusOK, res.StatusCode)
|
|
assert.Equal(t, "br", res.Header.Get(contentEncoding))
|
|
|
|
got, err := io.ReadAll(brotli.NewReader(res.Body))
|
|
require.NoError(t, err)
|
|
assert.Equal(t, bigTestBody, got)
|
|
}
|
|
|
|
func Test_FlushAfterWriteNil(t *testing.T) {
|
|
srv := httptest.NewServer(mustNewWrapper(t, Config{MinSize: 1024})(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
|
|
rw.WriteHeader(http.StatusOK)
|
|
|
|
_, err := rw.Write(nil)
|
|
require.NoError(t, err)
|
|
|
|
rw.(http.Flusher).Flush()
|
|
})))
|
|
defer srv.Close()
|
|
|
|
req, err := http.NewRequest(http.MethodGet, srv.URL, http.NoBody)
|
|
require.NoError(t, err)
|
|
|
|
req.Header.Set(acceptEncoding, "br")
|
|
|
|
res, err := http.DefaultClient.Do(req)
|
|
require.NoError(t, err)
|
|
|
|
defer res.Body.Close()
|
|
|
|
assert.Equal(t, http.StatusOK, res.StatusCode)
|
|
assert.Empty(t, res.Header.Get(contentEncoding))
|
|
|
|
got, err := io.ReadAll(brotli.NewReader(res.Body))
|
|
require.NoError(t, err)
|
|
assert.Empty(t, got)
|
|
}
|
|
|
|
func Test_FlushAfterAllWrites(t *testing.T) {
|
|
srv := httptest.NewServer(mustNewWrapper(t, Config{MinSize: 1024})(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
|
|
for i := range bigTestBody {
|
|
_, err := rw.Write(bigTestBody[i : i+1])
|
|
require.NoError(t, err)
|
|
}
|
|
rw.(http.Flusher).Flush()
|
|
})))
|
|
defer srv.Close()
|
|
|
|
req, err := http.NewRequest(http.MethodGet, srv.URL, http.NoBody)
|
|
require.NoError(t, err)
|
|
|
|
req.Header.Set(acceptEncoding, "br")
|
|
|
|
res, err := http.DefaultClient.Do(req)
|
|
require.NoError(t, err)
|
|
|
|
defer res.Body.Close()
|
|
|
|
assert.Equal(t, http.StatusOK, res.StatusCode)
|
|
assert.Equal(t, "br", res.Header.Get(contentEncoding))
|
|
|
|
got, err := io.ReadAll(brotli.NewReader(res.Body))
|
|
require.NoError(t, err)
|
|
assert.Equal(t, bigTestBody, got)
|
|
}
|
|
|
|
func Test_ExcludedContentTypes(t *testing.T) {
|
|
testCases := []struct {
|
|
desc string
|
|
contentType string
|
|
excludedContentTypes []string
|
|
expCompression bool
|
|
}{
|
|
{
|
|
desc: "Always compress when content types are empty",
|
|
contentType: "",
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match",
|
|
contentType: "application/json",
|
|
excludedContentTypes: []string{"application/json"},
|
|
expCompression: false,
|
|
},
|
|
{
|
|
desc: "MIME no match",
|
|
contentType: "text/xml",
|
|
excludedContentTypes: []string{"application/json"},
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match with no other directive ignores non-MIME directives",
|
|
contentType: "application/json; charset=utf-8",
|
|
excludedContentTypes: []string{"application/json"},
|
|
expCompression: false,
|
|
},
|
|
{
|
|
desc: "MIME match with other directives requires all directives be equal, different charset",
|
|
contentType: "application/json; charset=ascii",
|
|
excludedContentTypes: []string{"application/json; charset=utf-8"},
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match with other directives requires all directives be equal, same charset",
|
|
contentType: "application/json; charset=utf-8",
|
|
excludedContentTypes: []string{"application/json; charset=utf-8"},
|
|
expCompression: false,
|
|
},
|
|
{
|
|
desc: "MIME match with other directives requires all directives be equal, missing charset",
|
|
contentType: "application/json",
|
|
excludedContentTypes: []string{"application/json; charset=ascii"},
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match case insensitive",
|
|
contentType: "Application/Json",
|
|
excludedContentTypes: []string{"application/json"},
|
|
expCompression: false,
|
|
},
|
|
{
|
|
desc: "MIME match ignore whitespace",
|
|
contentType: "application/json;charset=utf-8",
|
|
excludedContentTypes: []string{"application/json; charset=utf-8"},
|
|
expCompression: false,
|
|
},
|
|
}
|
|
|
|
for _, test := range testCases {
|
|
test := test
|
|
t.Run(test.desc, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cfg := Config{
|
|
MinSize: 1024,
|
|
ExcludedContentTypes: test.excludedContentTypes,
|
|
}
|
|
h := mustNewWrapper(t, cfg)(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
|
|
rw.Header().Set(contentType, test.contentType)
|
|
|
|
rw.WriteHeader(http.StatusOK)
|
|
|
|
_, err := rw.Write(bigTestBody)
|
|
require.NoError(t, err)
|
|
}))
|
|
|
|
req, _ := http.NewRequest(http.MethodGet, "/whatever", nil)
|
|
req.Header.Set(acceptEncoding, "br")
|
|
|
|
rw := httptest.NewRecorder()
|
|
h.ServeHTTP(rw, req)
|
|
|
|
assert.Equal(t, http.StatusOK, rw.Code)
|
|
|
|
if test.expCompression {
|
|
assert.Equal(t, "br", rw.Header().Get(contentEncoding))
|
|
|
|
got, err := io.ReadAll(brotli.NewReader(rw.Body))
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, bigTestBody, got)
|
|
} else {
|
|
assert.NotEqual(t, "br", rw.Header().Get("Content-Encoding"))
|
|
|
|
got, err := io.ReadAll(rw.Body)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, bigTestBody, got)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_IncludedContentTypes(t *testing.T) {
|
|
testCases := []struct {
|
|
desc string
|
|
contentType string
|
|
includedContentTypes []string
|
|
expCompression bool
|
|
}{
|
|
{
|
|
desc: "Always compress when content types are empty",
|
|
contentType: "",
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match",
|
|
contentType: "application/json",
|
|
includedContentTypes: []string{"application/json"},
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME no match",
|
|
contentType: "text/xml",
|
|
includedContentTypes: []string{"application/json"},
|
|
expCompression: false,
|
|
},
|
|
{
|
|
desc: "MIME match with no other directive ignores non-MIME directives",
|
|
contentType: "application/json; charset=utf-8",
|
|
includedContentTypes: []string{"application/json"},
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match with other directives requires all directives be equal, different charset",
|
|
contentType: "application/json; charset=ascii",
|
|
includedContentTypes: []string{"application/json; charset=utf-8"},
|
|
expCompression: false,
|
|
},
|
|
{
|
|
desc: "MIME match with other directives requires all directives be equal, same charset",
|
|
contentType: "application/json; charset=utf-8",
|
|
includedContentTypes: []string{"application/json; charset=utf-8"},
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match with other directives requires all directives be equal, missing charset",
|
|
contentType: "application/json",
|
|
includedContentTypes: []string{"application/json; charset=ascii"},
|
|
expCompression: false,
|
|
},
|
|
{
|
|
desc: "MIME match case insensitive",
|
|
contentType: "Application/Json",
|
|
includedContentTypes: []string{"application/json"},
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match ignore whitespace",
|
|
contentType: "application/json;charset=utf-8",
|
|
includedContentTypes: []string{"application/json; charset=utf-8"},
|
|
expCompression: true,
|
|
},
|
|
}
|
|
|
|
for _, test := range testCases {
|
|
test := test
|
|
t.Run(test.desc, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cfg := Config{
|
|
MinSize: 1024,
|
|
IncludedContentTypes: test.includedContentTypes,
|
|
}
|
|
h := mustNewWrapper(t, cfg)(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
|
|
rw.Header().Set(contentType, test.contentType)
|
|
|
|
rw.WriteHeader(http.StatusOK)
|
|
|
|
_, err := rw.Write(bigTestBody)
|
|
require.NoError(t, err)
|
|
}))
|
|
|
|
req, _ := http.NewRequest(http.MethodGet, "/whatever", nil)
|
|
req.Header.Set(acceptEncoding, "br")
|
|
|
|
rw := httptest.NewRecorder()
|
|
h.ServeHTTP(rw, req)
|
|
|
|
assert.Equal(t, http.StatusOK, rw.Code)
|
|
|
|
if test.expCompression {
|
|
assert.Equal(t, "br", rw.Header().Get(contentEncoding))
|
|
|
|
got, err := io.ReadAll(brotli.NewReader(rw.Body))
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, bigTestBody, got)
|
|
} else {
|
|
assert.NotEqual(t, "br", rw.Header().Get("Content-Encoding"))
|
|
|
|
got, err := io.ReadAll(rw.Body)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, bigTestBody, got)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_FlushExcludedContentTypes(t *testing.T) {
|
|
testCases := []struct {
|
|
desc string
|
|
contentType string
|
|
excludedContentTypes []string
|
|
expCompression bool
|
|
}{
|
|
{
|
|
desc: "Always compress when content types are empty",
|
|
contentType: "",
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match",
|
|
contentType: "application/json",
|
|
excludedContentTypes: []string{"application/json"},
|
|
expCompression: false,
|
|
},
|
|
{
|
|
desc: "MIME no match",
|
|
contentType: "text/xml",
|
|
excludedContentTypes: []string{"application/json"},
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match with no other directive ignores non-MIME directives",
|
|
contentType: "application/json; charset=utf-8",
|
|
excludedContentTypes: []string{"application/json"},
|
|
expCompression: false,
|
|
},
|
|
{
|
|
desc: "MIME match with other directives requires all directives be equal, different charset",
|
|
contentType: "application/json; charset=ascii",
|
|
excludedContentTypes: []string{"application/json; charset=utf-8"},
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match with other directives requires all directives be equal, same charset",
|
|
contentType: "application/json; charset=utf-8",
|
|
excludedContentTypes: []string{"application/json; charset=utf-8"},
|
|
expCompression: false,
|
|
},
|
|
{
|
|
desc: "MIME match with other directives requires all directives be equal, missing charset",
|
|
contentType: "application/json",
|
|
excludedContentTypes: []string{"application/json; charset=ascii"},
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match case insensitive",
|
|
contentType: "Application/Json",
|
|
excludedContentTypes: []string{"application/json"},
|
|
expCompression: false,
|
|
},
|
|
{
|
|
desc: "MIME match ignore whitespace",
|
|
contentType: "application/json;charset=utf-8",
|
|
excludedContentTypes: []string{"application/json; charset=utf-8"},
|
|
expCompression: false,
|
|
},
|
|
}
|
|
|
|
for _, test := range testCases {
|
|
test := test
|
|
t.Run(test.desc, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cfg := Config{
|
|
MinSize: 1024,
|
|
ExcludedContentTypes: test.excludedContentTypes,
|
|
}
|
|
h := mustNewWrapper(t, cfg)(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
|
|
rw.Header().Set(contentType, test.contentType)
|
|
rw.WriteHeader(http.StatusOK)
|
|
|
|
tb := bigTestBody
|
|
for len(tb) > 0 {
|
|
// Write 100 bytes per run
|
|
// Detection should not be affected (we send 100 bytes)
|
|
toWrite := 100
|
|
if toWrite > len(tb) {
|
|
toWrite = len(tb)
|
|
}
|
|
|
|
_, err := rw.Write(tb[:toWrite])
|
|
require.NoError(t, err)
|
|
|
|
// Flush between each write
|
|
rw.(http.Flusher).Flush()
|
|
tb = tb[toWrite:]
|
|
}
|
|
}))
|
|
|
|
req, _ := http.NewRequest(http.MethodGet, "/whatever", nil)
|
|
req.Header.Set(acceptEncoding, "br")
|
|
|
|
// This doesn't allow checking flushes, but we validate if content is correct.
|
|
rw := httptest.NewRecorder()
|
|
h.ServeHTTP(rw, req)
|
|
|
|
assert.Equal(t, http.StatusOK, rw.Code)
|
|
|
|
if test.expCompression {
|
|
assert.Equal(t, "br", rw.Header().Get(contentEncoding))
|
|
|
|
got, err := io.ReadAll(brotli.NewReader(rw.Body))
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, bigTestBody, got)
|
|
} else {
|
|
assert.NotEqual(t, "br", rw.Header().Get(contentEncoding))
|
|
|
|
got, err := io.ReadAll(rw.Body)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, bigTestBody, got)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_FlushIncludedContentTypes(t *testing.T) {
|
|
testCases := []struct {
|
|
desc string
|
|
contentType string
|
|
includedContentTypes []string
|
|
expCompression bool
|
|
}{
|
|
{
|
|
desc: "Always compress when content types are empty",
|
|
contentType: "",
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match",
|
|
contentType: "application/json",
|
|
includedContentTypes: []string{"application/json"},
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME no match",
|
|
contentType: "text/xml",
|
|
includedContentTypes: []string{"application/json"},
|
|
expCompression: false,
|
|
},
|
|
{
|
|
desc: "MIME match with no other directive ignores non-MIME directives",
|
|
contentType: "application/json; charset=utf-8",
|
|
includedContentTypes: []string{"application/json"},
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match with other directives requires all directives be equal, different charset",
|
|
contentType: "application/json; charset=ascii",
|
|
includedContentTypes: []string{"application/json; charset=utf-8"},
|
|
expCompression: false,
|
|
},
|
|
{
|
|
desc: "MIME match with other directives requires all directives be equal, same charset",
|
|
contentType: "application/json; charset=utf-8",
|
|
includedContentTypes: []string{"application/json; charset=utf-8"},
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match with other directives requires all directives be equal, missing charset",
|
|
contentType: "application/json",
|
|
includedContentTypes: []string{"application/json; charset=ascii"},
|
|
expCompression: false,
|
|
},
|
|
{
|
|
desc: "MIME match case insensitive",
|
|
contentType: "Application/Json",
|
|
includedContentTypes: []string{"application/json"},
|
|
expCompression: true,
|
|
},
|
|
{
|
|
desc: "MIME match ignore whitespace",
|
|
contentType: "application/json;charset=utf-8",
|
|
includedContentTypes: []string{"application/json; charset=utf-8"},
|
|
expCompression: true,
|
|
},
|
|
}
|
|
|
|
for _, test := range testCases {
|
|
test := test
|
|
t.Run(test.desc, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cfg := Config{
|
|
MinSize: 1024,
|
|
IncludedContentTypes: test.includedContentTypes,
|
|
}
|
|
h := mustNewWrapper(t, cfg)(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
|
|
rw.Header().Set(contentType, test.contentType)
|
|
rw.WriteHeader(http.StatusOK)
|
|
|
|
tb := bigTestBody
|
|
for len(tb) > 0 {
|
|
// Write 100 bytes per run
|
|
// Detection should not be affected (we send 100 bytes)
|
|
toWrite := 100
|
|
if toWrite > len(tb) {
|
|
toWrite = len(tb)
|
|
}
|
|
|
|
_, err := rw.Write(tb[:toWrite])
|
|
require.NoError(t, err)
|
|
|
|
// Flush between each write
|
|
rw.(http.Flusher).Flush()
|
|
tb = tb[toWrite:]
|
|
}
|
|
}))
|
|
|
|
req, _ := http.NewRequest(http.MethodGet, "/whatever", nil)
|
|
req.Header.Set(acceptEncoding, "br")
|
|
|
|
// This doesn't allow checking flushes, but we validate if content is correct.
|
|
rw := httptest.NewRecorder()
|
|
h.ServeHTTP(rw, req)
|
|
|
|
assert.Equal(t, http.StatusOK, rw.Code)
|
|
|
|
if test.expCompression {
|
|
assert.Equal(t, "br", rw.Header().Get(contentEncoding))
|
|
|
|
got, err := io.ReadAll(brotli.NewReader(rw.Body))
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, bigTestBody, got)
|
|
} else {
|
|
assert.NotEqual(t, "br", rw.Header().Get(contentEncoding))
|
|
|
|
got, err := io.ReadAll(rw.Body)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, bigTestBody, got)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func mustNewWrapper(t *testing.T, cfg Config) func(http.Handler) http.HandlerFunc {
|
|
t.Helper()
|
|
|
|
w, err := NewWrapper(cfg)
|
|
require.NoError(t, err)
|
|
|
|
return w
|
|
}
|
|
|
|
func newTestHandler(t *testing.T, body []byte) http.Handler {
|
|
t.Helper()
|
|
|
|
return mustNewWrapper(t, Config{MinSize: 1024})(
|
|
http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
|
|
if req.URL.Path == "/compressed" {
|
|
rw.Header().Set("Content-Encoding", "br")
|
|
}
|
|
|
|
_, err := rw.Write(body)
|
|
require.NoError(t, err)
|
|
}),
|
|
)
|
|
}
|
|
|
|
func TestParseContentType_equals(t *testing.T) {
|
|
testCases := []struct {
|
|
desc string
|
|
pct parsedContentType
|
|
mediaType string
|
|
params map[string]string
|
|
expect assert.BoolAssertionFunc
|
|
}{
|
|
{
|
|
desc: "empty parsed content type",
|
|
expect: assert.True,
|
|
},
|
|
{
|
|
desc: "simple content type",
|
|
pct: parsedContentType{
|
|
mediaType: "plain/text",
|
|
},
|
|
mediaType: "plain/text",
|
|
expect: assert.True,
|
|
},
|
|
{
|
|
desc: "content type with params",
|
|
pct: parsedContentType{
|
|
mediaType: "plain/text",
|
|
params: map[string]string{
|
|
"charset": "utf8",
|
|
},
|
|
},
|
|
mediaType: "plain/text",
|
|
params: map[string]string{
|
|
"charset": "utf8",
|
|
},
|
|
expect: assert.True,
|
|
},
|
|
{
|
|
desc: "different content type",
|
|
pct: parsedContentType{
|
|
mediaType: "plain/text",
|
|
},
|
|
mediaType: "application/json",
|
|
expect: assert.False,
|
|
},
|
|
{
|
|
desc: "content type with params",
|
|
pct: parsedContentType{
|
|
mediaType: "plain/text",
|
|
params: map[string]string{
|
|
"charset": "utf8",
|
|
},
|
|
},
|
|
mediaType: "plain/text",
|
|
params: map[string]string{
|
|
"charset": "latin-1",
|
|
},
|
|
expect: assert.False,
|
|
},
|
|
{
|
|
desc: "different number of parameters",
|
|
pct: parsedContentType{
|
|
mediaType: "plain/text",
|
|
params: map[string]string{
|
|
"charset": "utf8",
|
|
},
|
|
},
|
|
mediaType: "plain/text",
|
|
params: map[string]string{
|
|
"charset": "utf8",
|
|
"q": "0.8",
|
|
},
|
|
expect: assert.False,
|
|
},
|
|
}
|
|
|
|
for _, test := range testCases {
|
|
test := test
|
|
|
|
t.Run(test.desc, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
test.expect(t, test.pct.equals(test.mediaType, test.params))
|
|
})
|
|
}
|
|
}
|