From db28ee1ff7b74573238f7b4bda7051725c1699ad Mon Sep 17 00:00:00 2001 From: Ludovic Fernandez Date: Sun, 19 Jan 2020 23:00:06 +0100 Subject: [PATCH] Update golangci-lint version. --- .golangci.toml | 7 +++++++ build.Dockerfile | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/.golangci.toml b/.golangci.toml index 006728e82..30fb95f58 100644 --- a/.golangci.toml +++ b/.golangci.toml @@ -47,6 +47,7 @@ "gocognit", "bodyclose", # Too many false-positive and panics. "wsl", # Too strict + "gomnd", # Too strict "stylecheck", # skip because report issues related to some generated files. ] @@ -95,3 +96,9 @@ [[issues.exclude-rules]] # FIXME must be fixed path = "cmd/context.go" text = "S1000: should use a simple channel send/receive instead of `select` with a single case" + [[issues.exclude-rules]] + path = "pkg/tracing/haystack/logger.go" + linters = ["goprintffuncname"] + [[issues.exclude-rules]] + path = "pkg/tracing/tracing.go" + text = "printf-like formatting function 'SetErrorWithEvent' should be named 'SetErrorWithEventf'" diff --git a/build.Dockerfile b/build.Dockerfile index a37091948..e7d682e44 100644 --- a/build.Dockerfile +++ b/build.Dockerfile @@ -19,7 +19,7 @@ RUN mkdir -p /usr/local/bin \ && chmod +x /usr/local/bin/go-bindata # Download golangci-lint binary to bin folder in $GOPATH -RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b $GOPATH/bin v1.20.0 +RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b $GOPATH/bin v1.23.0 # Download golangci-lint and misspell binary to bin folder in $GOPATH RUN GO111MODULE=off go get github.com/client9/misspell/cmd/misspell