feat: API REST endpoint review

This commit is contained in:
Fernandez Ludovic 2015-10-05 16:01:34 +02:00
parent dece3bbf13
commit a7a942fbeb

202
web.go
View file

@ -6,7 +6,6 @@ import (
"io/ioutil" "io/ioutil"
"net/http" "net/http"
"github.com/BurntSushi/ty/fun"
log "github.com/Sirupsen/logrus" log "github.com/Sirupsen/logrus"
"github.com/elazarl/go-bindata-assetfs" "github.com/elazarl/go-bindata-assetfs"
"github.com/gorilla/mux" "github.com/gorilla/mux"
@ -17,44 +16,47 @@ type WebProvider struct {
CertFile, KeyFile string CertFile, KeyFile string
} }
type Page struct {
Configurations configs
}
func (provider *WebProvider) Provide(configurationChan chan<- configMessage) error { func (provider *WebProvider) Provide(configurationChan chan<- configMessage) error {
systemRouter := mux.NewRouter() systemRouter := mux.NewRouter()
systemRouter.Methods("GET").Path("/").Handler(http.HandlerFunc(GetHTMLConfigHandler))
systemRouter.Methods("GET").Path("/health").Handler(http.HandlerFunc(GetHealthHandler))
systemRouter.Methods("GET").Path("/api").Handler(http.HandlerFunc(GetConfigHandler))
systemRouter.Methods("GET").Path("/api/providers").Handler(http.HandlerFunc(GetProvidersHandler))
systemRouter.Methods("GET").Path("/api/providers/{provider}").Handler(http.HandlerFunc(GetConfigHandler))
systemRouter.Methods("PUT").Path("/api/providers/{provider}").Handler(http.HandlerFunc(
func(rw http.ResponseWriter, r *http.Request) {
vars := mux.Vars(r)
if vars["provider"] != "web" {
rw.WriteHeader(http.StatusBadRequest)
fmt.Fprintf(rw, "Only 'web' provider can be updated through the REST API")
return
}
configuration := new(Configuration) // health route
b, _ := ioutil.ReadAll(r.Body) systemRouter.Methods("GET").Path("/health").HandlerFunc(getHealthHandler)
err := json.Unmarshal(b, configuration)
if err == nil { // API routes
configurationChan <- configMessage{"web", configuration} systemRouter.Methods("GET").Path("/api").HandlerFunc(getConfigHandler)
GetConfigHandler(rw, r) systemRouter.Methods("GET").Path("/api/providers").HandlerFunc(getConfigHandler)
} else { systemRouter.Methods("GET").Path("/api/providers/{provider}").HandlerFunc(getProviderHandler)
log.Errorf("Error parsing configuration %+v", err) systemRouter.Methods("PUT").Path("/api/providers/{provider}").HandlerFunc(func(response http.ResponseWriter, request *http.Request) {
http.Error(rw, fmt.Sprintf("%+v", err), http.StatusBadRequest) vars := mux.Vars(request)
} if vars["provider"] != "web" {
})) response.WriteHeader(http.StatusBadRequest)
systemRouter.Methods("GET").Path("/api/providers/{provider}/backends").Handler(http.HandlerFunc(GetBackendsHandler)) fmt.Fprintf(response, "Only 'web' provider can be updated through the REST API")
systemRouter.Methods("GET").Path("/api/providers/{provider}/backends/{backend}").Handler(http.HandlerFunc(GetBackendHandler)) return
systemRouter.Methods("GET").Path("/api/providers/{provider}/backends/{backend}/servers").Handler(http.HandlerFunc(GetServersHandler)) }
systemRouter.Methods("GET").Path("/api/providers/{provider}/backends/{backend}/servers/{server}").Handler(http.HandlerFunc(GetServerHandler))
systemRouter.Methods("GET").Path("/api/providers/{provider}/frontends").Handler(http.HandlerFunc(GetFrontendsHandler)) configuration := new(Configuration)
systemRouter.Methods("GET").Path("/api/providers/{provider}/frontends/{frontend}").Handler(http.HandlerFunc(GetFrontendHandler)) body, _ := ioutil.ReadAll(request.Body)
systemRouter.Methods("GET").PathPrefix("/static/").Handler(http.StripPrefix("/static/", http.FileServer(&assetfs.AssetFS{Asset: Asset, AssetDir: AssetDir, Prefix: "static"}))) err := json.Unmarshal(body, configuration)
if err == nil {
configurationChan <- configMessage{"web", configuration}
getConfigHandler(response, request)
} else {
log.Errorf("Error parsing configuration %+v", err)
http.Error(response, fmt.Sprintf("%+v", err), http.StatusBadRequest)
}
})
systemRouter.Methods("GET").Path("/api/providers/{provider}/backends").HandlerFunc(getBackendsHandler)
systemRouter.Methods("GET").Path("/api/providers/{provider}/backends/{backend}").HandlerFunc(getBackendHandler)
systemRouter.Methods("GET").Path("/api/providers/{provider}/backends/{backend}/servers").HandlerFunc(getServersHandler)
systemRouter.Methods("GET").Path("/api/providers/{provider}/backends/{backend}/servers/{server}").HandlerFunc(getServerHandler)
systemRouter.Methods("GET").Path("/api/providers/{provider}/frontends").HandlerFunc(getFrontendsHandler)
systemRouter.Methods("GET").Path("/api/providers/{provider}/frontends/{frontend}").HandlerFunc(getFrontendHandler)
// Expose dashboard
systemRouter.Methods("GET").Path("/").HandlerFunc(func(response http.ResponseWriter, request *http.Request) {
http.Redirect(response, request, "/dashboard/", 302)
})
systemRouter.Methods("GET").PathPrefix("/dashboard/").Handler(http.StripPrefix("/dashboard/", http.FileServer(&assetfs.AssetFS{Asset: Asset, AssetDir: AssetDir, Prefix: "static"})))
go func() { go func() {
if len(provider.CertFile) > 0 && len(provider.KeyFile) > 0 { if len(provider.CertFile) > 0 && len(provider.KeyFile) > 0 {
@ -72,93 +74,95 @@ func (provider *WebProvider) Provide(configurationChan chan<- configMessage) err
return nil return nil
} }
func GetConfigHandler(rw http.ResponseWriter, r *http.Request) { func getHealthHandler(response http.ResponseWriter, request *http.Request) {
templatesRenderer.JSON(rw, http.StatusOK, currentConfigurations) templatesRenderer.JSON(response, http.StatusOK, metrics.Data())
} }
func GetHTMLConfigHandler(response http.ResponseWriter, request *http.Request) { func getConfigHandler(response http.ResponseWriter, request *http.Request) {
templatesRenderer.HTML(response, http.StatusOK, "configuration", Page{Configurations: currentConfigurations}) templatesRenderer.JSON(response, http.StatusOK, currentConfigurations)
} }
func GetHealthHandler(rw http.ResponseWriter, r *http.Request) { func getProviderHandler(response http.ResponseWriter, request *http.Request) {
templatesRenderer.JSON(rw, http.StatusOK, metrics.Data()) vars := mux.Vars(request)
} providerID := vars["provider"]
if provider, ok := currentConfigurations[providerID]; ok {
func GetProvidersHandler(rw http.ResponseWriter, r *http.Request) { templatesRenderer.JSON(response, http.StatusOK, provider)
templatesRenderer.JSON(rw, http.StatusOK, fun.Keys(currentConfigurations))
}
func GetBackendsHandler(rw http.ResponseWriter, r *http.Request) {
vars := mux.Vars(r)
providerId := vars["provider"]
if provider, ok := currentConfigurations[providerId]; ok {
templatesRenderer.JSON(rw, http.StatusOK, provider.Backends)
} else { } else {
http.NotFound(rw, r) http.NotFound(response, request)
} }
} }
func GetBackendHandler(rw http.ResponseWriter, r *http.Request) { func getBackendsHandler(response http.ResponseWriter, request *http.Request) {
vars := mux.Vars(r) vars := mux.Vars(request)
providerId := vars["provider"] providerID := vars["provider"]
backendId := vars["backend"] if provider, ok := currentConfigurations[providerID]; ok {
if provider, ok := currentConfigurations[providerId]; ok { templatesRenderer.JSON(response, http.StatusOK, provider.Backends)
if backend, ok := provider.Backends[backendId]; ok {
templatesRenderer.JSON(rw, http.StatusOK, backend)
return
}
}
http.NotFound(rw, r)
}
func GetFrontendsHandler(rw http.ResponseWriter, r *http.Request) {
vars := mux.Vars(r)
providerId := vars["provider"]
if provider, ok := currentConfigurations[providerId]; ok {
templatesRenderer.JSON(rw, http.StatusOK, provider.Frontends)
} else { } else {
http.NotFound(rw, r) http.NotFound(response, request)
} }
} }
func GetFrontendHandler(rw http.ResponseWriter, r *http.Request) { func getBackendHandler(response http.ResponseWriter, request *http.Request) {
vars := mux.Vars(r) vars := mux.Vars(request)
providerId := vars["provider"] providerID := vars["provider"]
frontendId := vars["frontend"] backendID := vars["backend"]
if provider, ok := currentConfigurations[providerId]; ok { if provider, ok := currentConfigurations[providerID]; ok {
if frontend, ok := provider.Frontends[frontendId]; ok { if backend, ok := provider.Backends[backendID]; ok {
templatesRenderer.JSON(rw, http.StatusOK, frontend) templatesRenderer.JSON(response, http.StatusOK, backend)
return return
} }
} }
http.NotFound(rw, r) http.NotFound(response, request)
} }
func GetServersHandler(rw http.ResponseWriter, r *http.Request) { func getFrontendsHandler(response http.ResponseWriter, request *http.Request) {
vars := mux.Vars(r) vars := mux.Vars(request)
providerId := vars["provider"] providerID := vars["provider"]
backendId := vars["backend"] if provider, ok := currentConfigurations[providerID]; ok {
if provider, ok := currentConfigurations[providerId]; ok { templatesRenderer.JSON(response, http.StatusOK, provider.Frontends)
if backend, ok := provider.Backends[backendId]; ok { } else {
templatesRenderer.JSON(rw, http.StatusOK, backend.Servers) http.NotFound(response, request)
}
}
func getFrontendHandler(response http.ResponseWriter, request *http.Request) {
vars := mux.Vars(request)
providerID := vars["provider"]
frontendID := vars["frontend"]
if provider, ok := currentConfigurations[providerID]; ok {
if frontend, ok := provider.Frontends[frontendID]; ok {
templatesRenderer.JSON(response, http.StatusOK, frontend)
return return
} }
} }
http.NotFound(rw, r) http.NotFound(response, request)
} }
func GetServerHandler(rw http.ResponseWriter, r *http.Request) { func getServersHandler(response http.ResponseWriter, request *http.Request) {
vars := mux.Vars(r) vars := mux.Vars(request)
providerId := vars["provider"] providerID := vars["provider"]
backendId := vars["backend"] backendID := vars["backend"]
serverId := vars["server"] if provider, ok := currentConfigurations[providerID]; ok {
if provider, ok := currentConfigurations[providerId]; ok { if backend, ok := provider.Backends[backendID]; ok {
if backend, ok := provider.Backends[backendId]; ok { templatesRenderer.JSON(response, http.StatusOK, backend.Servers)
if server, ok := backend.Servers[serverId]; ok { return
templatesRenderer.JSON(rw, http.StatusOK, server) }
}
http.NotFound(response, request)
}
func getServerHandler(response http.ResponseWriter, request *http.Request) {
vars := mux.Vars(request)
providerID := vars["provider"]
backendID := vars["backend"]
serverID := vars["server"]
if provider, ok := currentConfigurations[providerID]; ok {
if backend, ok := provider.Backends[backendID]; ok {
if server, ok := backend.Servers[serverID]; ok {
templatesRenderer.JSON(response, http.StatusOK, server)
return return
} }
} }
} }
http.NotFound(rw, r) http.NotFound(response, request)
} }