diff --git a/pkg/provider/kubernetes/k8s/event_handler.go b/pkg/provider/kubernetes/k8s/event_handler.go index 155c01253..92b450bec 100644 --- a/pkg/provider/kubernetes/k8s/event_handler.go +++ b/pkg/provider/kubernetes/k8s/event_handler.go @@ -48,12 +48,10 @@ func objChanged(oldObj, newObj interface{}) bool { } if _, ok := oldObj.(*corev1.Endpoints); ok { - if endpointsChanged(oldObj.(*corev1.Endpoints), newObj.(*corev1.Endpoints)) { - return true - } + return endpointsChanged(oldObj.(*corev1.Endpoints), newObj.(*corev1.Endpoints)) } - return false + return true } func endpointsChanged(a, b *corev1.Endpoints) bool { diff --git a/pkg/provider/kubernetes/k8s/event_handler_test.go b/pkg/provider/kubernetes/k8s/event_handler_test.go index a2bbfb0c5..8f75ebbd2 100644 --- a/pkg/provider/kubernetes/k8s/event_handler_test.go +++ b/pkg/provider/kubernetes/k8s/event_handler_test.go @@ -5,6 +5,7 @@ import ( "github.com/stretchr/testify/assert" corev1 "k8s.io/api/core/v1" + v1 "k8s.io/api/networking/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" ) @@ -60,6 +61,33 @@ func Test_detectChanges(t *testing.T) { }, }, }, + { + name: "Ingress With same version", + oldObj: &v1.Ingress{ + ObjectMeta: metav1.ObjectMeta{ + ResourceVersion: "1", + }, + }, + newObj: &v1.Ingress{ + ObjectMeta: metav1.ObjectMeta{ + ResourceVersion: "1", + }, + }, + }, + { + name: "Ingress With different version", + oldObj: &v1.Ingress{ + ObjectMeta: metav1.ObjectMeta{ + ResourceVersion: "1", + }, + }, + newObj: &v1.Ingress{ + ObjectMeta: metav1.ObjectMeta{ + ResourceVersion: "2", + }, + }, + want: true, + }, { name: "With same annotations", oldObj: &corev1.Endpoints{