From 9e96089da64be1373c78738fbdce91751fbc2730 Mon Sep 17 00:00:00 2001 From: Sakala Venkata Krishna Rohit Date: Tue, 15 Feb 2022 14:38:08 +0530 Subject: [PATCH 1/7] Add s390x arch support --- .goreleaser.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.goreleaser.yml b/.goreleaser.yml index 545ca5281..77186c309 100644 --- a/.goreleaser.yml +++ b/.goreleaser.yml @@ -25,6 +25,7 @@ builds: - arm - arm64 - ppc64le + - s390x goarm: - 7 - 6 From 371b6e3c867df5462c1434b19038f10ba22a10b9 Mon Sep 17 00:00:00 2001 From: Ludovic Fernandez Date: Tue, 15 Feb 2022 14:56:53 +0100 Subject: [PATCH 2/7] chore: update linter --- .github/workflows/validate.yaml | 2 +- .golangci.toml | 2 ++ .semaphore/semaphore.yml | 2 +- build.Dockerfile | 2 +- integration/consul_catalog_test.go | 1 - pkg/config/runtime/runtime_http_test.go | 1 - pkg/config/runtime/runtime_tcp_test.go | 1 - pkg/config/runtime/runtime_udp_test.go | 1 - pkg/middlewares/stripprefix/strip_prefix_test.go | 1 - pkg/provider/kubernetes/crd/client.go | 2 -- pkg/provider/kubernetes/gateway/client.go | 2 -- pkg/server/router/udp/router_test.go | 2 -- 12 files changed, 5 insertions(+), 14 deletions(-) diff --git a/.github/workflows/validate.yaml b/.github/workflows/validate.yaml index e24e1a40e..5fb080436 100644 --- a/.github/workflows/validate.yaml +++ b/.github/workflows/validate.yaml @@ -7,7 +7,7 @@ on: env: GO_VERSION: 1.17 - GOLANGCI_LINT_VERSION: v1.43.0 + GOLANGCI_LINT_VERSION: v1.44.0 MISSSPELL_VERSION: v0.3.4 PRE_TARGET: "" diff --git a/.golangci.toml b/.golangci.toml index ff16616fe..73908f11c 100644 --- a/.golangci.toml +++ b/.golangci.toml @@ -102,6 +102,8 @@ "nilnil", # not relevant "ireturn", # not relevant "contextcheck", # too many false-positive + "containedctx", # too many false-positive + "maintidx", # kind of duplicate of gocyclo ] [issues] diff --git a/.semaphore/semaphore.yml b/.semaphore/semaphore.yml index 9c66efc4f..52f359b13 100644 --- a/.semaphore/semaphore.yml +++ b/.semaphore/semaphore.yml @@ -25,7 +25,7 @@ global_job_config: - export "PATH=${GOPATH}/bin:${PATH}" - mkdir -vp "${SEMAPHORE_GIT_DIR}" "${GOPATH}/bin" - export GOPROXY=https://proxy.golang.org,direct - - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b "${GOPATH}/bin" v1.43.0 + - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b "${GOPATH}/bin" v1.44.0 - curl -sSfL https://gist.githubusercontent.com/traefiker/6d7ac019c11d011e4f131bb2cca8900e/raw/goreleaser.sh | bash -s -- -b "${GOPATH}/bin" - checkout - cache restore traefik-$(checksum go.sum) diff --git a/build.Dockerfile b/build.Dockerfile index db189b940..3025a75e9 100644 --- a/build.Dockerfile +++ b/build.Dockerfile @@ -14,7 +14,7 @@ RUN mkdir -p /usr/local/bin \ | tar -xzC /usr/local/bin --transform 's#^.+/##x' # Download golangci-lint binary to bin folder in $GOPATH -RUN curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | bash -s -- -b $GOPATH/bin v1.43.0 +RUN curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | bash -s -- -b $GOPATH/bin v1.44.0 # Download misspell binary to bin folder in $GOPATH RUN curl -sfL https://raw.githubusercontent.com/client9/misspell/master/install-misspell.sh | bash -s -- -b $GOPATH/bin v0.3.4 diff --git a/integration/consul_catalog_test.go b/integration/consul_catalog_test.go index 11b6fbf68..55f33f1dc 100644 --- a/integration/consul_catalog_test.go +++ b/integration/consul_catalog_test.go @@ -277,7 +277,6 @@ func (s *ConsulCatalogSuite) TestDefaultConsulService(c *check.C) { ConsulAddress string DefaultRule string }{ - ConsulAddress: s.consulURL, DefaultRule: "Host(`{{ normalize .Name }}.consul.localhost`)", } diff --git a/pkg/config/runtime/runtime_http_test.go b/pkg/config/runtime/runtime_http_test.go index dfb77d314..9ac028bfb 100644 --- a/pkg/config/runtime/runtime_http_test.go +++ b/pkg/config/runtime/runtime_http_test.go @@ -186,7 +186,6 @@ func TestGetRoutersByEntryPoints(t *testing.T) { "webs": { "bar": { Router: &dynamic.Router{ - EntryPoints: []string{"webs"}, Service: "bar-service@myprovider", Rule: "Host(`foo.bar`)", diff --git a/pkg/config/runtime/runtime_tcp_test.go b/pkg/config/runtime/runtime_tcp_test.go index 0bd51e58b..067e9ee09 100644 --- a/pkg/config/runtime/runtime_tcp_test.go +++ b/pkg/config/runtime/runtime_tcp_test.go @@ -186,7 +186,6 @@ func TestGetTCPRoutersByEntryPoints(t *testing.T) { "webs": { "bar": { TCPRouter: &dynamic.TCPRouter{ - EntryPoints: []string{"webs"}, Service: "bar-service@myprovider", Rule: "HostSNI(`foo.bar`)", diff --git a/pkg/config/runtime/runtime_udp_test.go b/pkg/config/runtime/runtime_udp_test.go index 10c1e80cb..87fe2476f 100644 --- a/pkg/config/runtime/runtime_udp_test.go +++ b/pkg/config/runtime/runtime_udp_test.go @@ -169,7 +169,6 @@ func TestGetUDPRoutersByEntryPoints(t *testing.T) { "webs": { "bar": { UDPRouter: &dynamic.UDPRouter{ - EntryPoints: []string{"webs"}, Service: "bar-service@myprovider", }, diff --git a/pkg/middlewares/stripprefix/strip_prefix_test.go b/pkg/middlewares/stripprefix/strip_prefix_test.go index 717acdef3..5c9d7171e 100644 --- a/pkg/middlewares/stripprefix/strip_prefix_test.go +++ b/pkg/middlewares/stripprefix/strip_prefix_test.go @@ -126,7 +126,6 @@ func TestStripPrefix(t *testing.T) { { desc: "earlier prefix matching", config: dynamic.StripPrefix{ - Prefixes: []string{"/stat", "/stat/us"}, }, path: "/stat/us", diff --git a/pkg/provider/kubernetes/crd/client.go b/pkg/provider/kubernetes/crd/client.go index 549ae575d..4dfd4d8a3 100644 --- a/pkg/provider/kubernetes/crd/client.go +++ b/pkg/provider/kubernetes/crd/client.go @@ -31,7 +31,6 @@ const resyncPeriod = 10 * time.Minute // The stores can then be accessed via the Get* functions. type Client interface { WatchAll(namespaces []string, stopCh <-chan struct{}) (<-chan interface{}, error) - GetIngressRoutes() []*v1alpha1.IngressRoute GetIngressRouteTCPs() []*v1alpha1.IngressRouteTCP GetIngressRouteUDPs() []*v1alpha1.IngressRouteUDP @@ -42,7 +41,6 @@ type Client interface { GetTLSOptions() []*v1alpha1.TLSOption GetServersTransports() []*v1alpha1.ServersTransport GetTLSStores() []*v1alpha1.TLSStore - GetService(namespace, name string) (*corev1.Service, bool, error) GetSecret(namespace, name string) (*corev1.Secret, bool, error) GetEndpoints(namespace, name string) (*corev1.Endpoints, bool, error) diff --git a/pkg/provider/kubernetes/gateway/client.go b/pkg/provider/kubernetes/gateway/client.go index db7715d62..e8317e45f 100644 --- a/pkg/provider/kubernetes/gateway/client.go +++ b/pkg/provider/kubernetes/gateway/client.go @@ -50,7 +50,6 @@ func (reh *resourceEventHandler) OnDelete(obj interface{}) { // The stores can then be accessed via the Get* functions. type Client interface { WatchAll(namespaces []string, stopCh <-chan struct{}) (<-chan interface{}, error) - GetGatewayClasses() ([]*v1alpha2.GatewayClass, error) UpdateGatewayStatus(gateway *v1alpha2.Gateway, gatewayStatus v1alpha2.GatewayStatus) error UpdateGatewayClassStatus(gatewayClass *v1alpha2.GatewayClass, condition metav1.Condition) error @@ -58,7 +57,6 @@ type Client interface { GetHTTPRoutes(namespaces []string) ([]*v1alpha2.HTTPRoute, error) GetTCPRoutes(namespaces []string) ([]*v1alpha2.TCPRoute, error) GetTLSRoutes(namespaces []string) ([]*v1alpha2.TLSRoute, error) - GetService(namespace, name string) (*corev1.Service, bool, error) GetSecret(namespace, name string) (*corev1.Secret, bool, error) GetEndpoints(namespace, name string) (*corev1.Endpoints, bool, error) diff --git a/pkg/server/router/udp/router_test.go b/pkg/server/router/udp/router_test.go index 76451cd30..d29d7d2d6 100644 --- a/pkg/server/router/udp/router_test.go +++ b/pkg/server/router/udp/router_test.go @@ -46,7 +46,6 @@ func TestRuntimeConfiguration(t *testing.T) { }, "bar": { UDPRouter: &dynamic.UDPRouter{ - EntryPoints: []string{"web"}, Service: "foo-service", }, @@ -78,7 +77,6 @@ func TestRuntimeConfiguration(t *testing.T) { }, "bar": { UDPRouter: &dynamic.UDPRouter{ - EntryPoints: []string{"web"}, Service: "foo-service", }, From 6974f54bfd48d8e8774386cdd770e712ad1c972b Mon Sep 17 00:00:00 2001 From: Ludovic Fernandez Date: Tue, 15 Feb 2022 17:04:34 +0100 Subject: [PATCH 3/7] docs: fix product name --- .github/workflows/documentation.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/documentation.yml b/.github/workflows/documentation.yml index d0df001bb..66227331f 100644 --- a/.github/workflows/documentation.yml +++ b/.github/workflows/documentation.yml @@ -44,7 +44,7 @@ jobs: STRUCTOR_LATEST_TAG: ${{ secrets.STRUCTOR_LATEST_TAG }} - name: Apply seo - run: $HOME/bin/seo -path=./site + run: $HOME/bin/seo -path=./site -product=traefik - name: Publish documentation run: $HOME/bin/mixtus --dst-doc-path="./traefik" --dst-owner=traefik --dst-repo-name=doc --git-user-email="30906710+traefiker@users.noreply.github.com" --git-user-name=traefiker --src-doc-path="./site" --src-owner=containous --src-repo-name=traefik From fb23bd5d269622dbf3cd34f9d645bda3a5e3b230 Mon Sep 17 00:00:00 2001 From: Romain Date: Fri, 18 Feb 2022 15:44:08 +0100 Subject: [PATCH 4/7] Fix empty WebUI static assets directory --- .github/workflows/build.yaml | 2 +- .github/workflows/test-unit.yaml | 2 +- .github/workflows/validate.yaml | 2 +- .gitignore | 1 - .semaphore/semaphore.yml | 2 +- Makefile | 13 ++++++++----- docs/content/contributing/building-testing.md | 2 +- webui/.gitignore | 4 ++++ webui/dev/scripts/transfer.js | 1 + webui/readme.md | 16 ++++++++-------- .../static/DONT-EDIT-FILES-IN-THIS-DIRECTORY.md | 1 + 11 files changed, 27 insertions(+), 19 deletions(-) create mode 100644 webui/static/DONT-EDIT-FILES-IN-THIS-DIRECTORY.md diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 49e945f2c..7a4d8c996 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -23,7 +23,7 @@ jobs: - name: Build webui run: | - make generate-webui + make clean-webui generate-webui tar czvf webui.tar.gz ./webui/static/ - name: Artifact webui diff --git a/.github/workflows/test-unit.yaml b/.github/workflows/test-unit.yaml index a1d861a31..3502c2a92 100644 --- a/.github/workflows/test-unit.yaml +++ b/.github/workflows/test-unit.yaml @@ -40,7 +40,7 @@ jobs: restore-keys: ${{ runner.os }}-test-unit-go- - name: Avoid generating webui - run: mkdir -p webui/static && touch webui/static/index.html + run: touch webui/static/index.html - name: Tests run: make test-unit diff --git a/.github/workflows/validate.yaml b/.github/workflows/validate.yaml index 5fb080436..d6b637642 100644 --- a/.github/workflows/validate.yaml +++ b/.github/workflows/validate.yaml @@ -48,7 +48,7 @@ jobs: run: curl -sfL https://raw.githubusercontent.com/client9/misspell/master/install-misspell.sh | sh -s -- -b $(go env GOPATH)/bin ${MISSSPELL_VERSION} - name: Avoid generating webui - run: mkdir -p webui/static && touch webui/static/index.html + run: touch webui/static/index.html - name: Validate run: make validate diff --git a/.gitignore b/.gitignore index 7cb18a276..461f51e8a 100644 --- a/.gitignore +++ b/.gitignore @@ -5,7 +5,6 @@ .DS_Store /dist /webui/.tmp/ -/webui/static/ /site/ /docs/site/ /autogen/ diff --git a/.semaphore/semaphore.yml b/.semaphore/semaphore.yml index 52f359b13..a77104b2b 100644 --- a/.semaphore/semaphore.yml +++ b/.semaphore/semaphore.yml @@ -40,7 +40,7 @@ blocks: - name: Test Integration commands: - make pull-images - - mkdir -p webui/static && touch webui/static/index.html # Avoid generating webui + - touch webui/static/index.html # Avoid generating webui - PRE_TARGET="" make binary - make test-integration - df -h diff --git a/Makefile b/Makefile index 338583ad8..be6a15272 100644 --- a/Makefile +++ b/Makefile @@ -58,14 +58,18 @@ dist: build-webui-image: docker build -t traefik-webui --build-arg ARG_PLATFORM_URL=$(PLATFORM_URL) -f webui/Dockerfile webui +## Clean WebUI static generated assets +clean-webui: + rm -r webui/static + mkdir -p webui/static + echo 'For more information show `webui/readme.md`' > webui/static/DONT-EDIT-FILES-IN-THIS-DIRECTORY.md + ## Generate WebUI generate-webui: - if [ ! -d "webui/static" ]; then \ + if [ ! -f "webui/static/index.html" ]; then \ $(MAKE) build-webui-image; \ - mkdir -p webui/static; \ docker run --rm -v "$$PWD/webui/static":'/src/webui/static' traefik-webui npm run build:nc; \ docker run --rm -v "$$PWD/webui/static":'/src/webui/static' traefik-webui chown -R $(shell id -u):$(shell id -g) ./static; \ - echo 'For more information show `webui/readme.md`' > $$PWD/webui/static/DONT-EDIT-FILES-IN-THIS-DIRECTORY.md; \ fi ## Build the linux binary @@ -114,8 +118,7 @@ validate: $(PRE_TARGET) bash $(CURDIR)/script/validate-shell-script.sh ## Clean up static directory and build a Docker Traefik image -build-image: binary - rm -rf webui/static +build-image: clean-webui binary docker build -t $(TRAEFIK_IMAGE) . ## Build a Docker Traefik image diff --git a/docs/content/contributing/building-testing.md b/docs/content/contributing/building-testing.md index 7572e2f6e..9c96ae784 100644 --- a/docs/content/contributing/building-testing.md +++ b/docs/content/contributing/building-testing.md @@ -102,7 +102,7 @@ Once you've set up your go environment and cloned the source repository, you can ```bash # Generate UI static files -rm -rf ./webui/static/; make generate-webui +make clean-webui generate-webui # required to merge non-code components into the final binary, # such as the web dashboard/UI diff --git a/webui/.gitignore b/webui/.gitignore index 94d7eb53f..db32ba46c 100644 --- a/webui/.gitignore +++ b/webui/.gitignore @@ -26,3 +26,7 @@ yarn-error.log* # local env files .env.local .env.*.local + +# static assets (ignore all except the DO NOT EDIT file) +static/* +!static/DONT-EDIT-FILES-IN-THIS-DIRECTORY.md diff --git a/webui/dev/scripts/transfer.js b/webui/dev/scripts/transfer.js index d6ec3c4fc..ed812efff 100644 --- a/webui/dev/scripts/transfer.js +++ b/webui/dev/scripts/transfer.js @@ -5,6 +5,7 @@ const folder = process.argv[2] async function execute () { try { await fs.emptyDir('./static') + await fs.outputFile('./static/DONT-EDIT-FILES-IN-THIS-DIRECTORY.md', 'For more information show `webui/readme.md`') console.log('Deleted static folder contents!') await fs.copy(`./dist/${folder}`, './static', { overwrite: true }) console.log('Installed new files in static folder!') diff --git a/webui/readme.md b/webui/readme.md index 426698bbe..8d23a7a8b 100644 --- a/webui/readme.md +++ b/webui/readme.md @@ -14,15 +14,15 @@ Traefik Web UI provide 2 types of information: Use the make file : ```shell -make build-image # Generate Docker image -make generate-webui # Generate static contents in `traefik/webui/static/` folder. +make build-image # Generate Docker image. +make clean-webui generate-webui # Generate static contents in `webui/static/` folder. ``` ## How to build (only for frontend developer) - prerequisite: [Node 12.11+](https://nodejs.org) [Npm](https://www.npmjs.com/) -- Go to the `webui` directory +- Go to the `webui/` directory - To install dependencies, execute the following commands: @@ -32,9 +32,9 @@ make generate-webui # Generate static contents in `traefik/webui/static/` fold - `npm run build` -- Static contents are built in the `webui/static` directory +- Static contents are built in the `webui/static/` directory -**Do not manually change the files in the `webui/static` directory** +**Do not manually change the files in the `webui/static/` directory** - The build allows to: - optimize all JavaScript @@ -46,10 +46,10 @@ make generate-webui # Generate static contents in `traefik/webui/static/` fold ## How to edit (only for frontend developer) -**Do not manually change the files in the `webui/static` directory** +**Do not manually change the files in the `webui/static/` directory** -- Go to the `webui` directory -- Edit files in `webui/src` +- Go to the `webui/` directory +- Edit files in `webui/src/` - Run in development mode : - `npm run dev` diff --git a/webui/static/DONT-EDIT-FILES-IN-THIS-DIRECTORY.md b/webui/static/DONT-EDIT-FILES-IN-THIS-DIRECTORY.md new file mode 100644 index 000000000..a0965fd38 --- /dev/null +++ b/webui/static/DONT-EDIT-FILES-IN-THIS-DIRECTORY.md @@ -0,0 +1 @@ +For more information show `webui/readme.md` \ No newline at end of file From 7e390ef516ff8431e9d1b7ada4f90484335dd8b8 Mon Sep 17 00:00:00 2001 From: 0xflotus <0xflotus@gmail.com> Date: Mon, 21 Feb 2022 10:50:08 +0100 Subject: [PATCH 5/7] Fix brand typo --- docs/content/user-guides/marathon.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/content/user-guides/marathon.md b/docs/content/user-guides/marathon.md index 091d9833c..bfd380048 100644 --- a/docs/content/user-guides/marathon.md +++ b/docs/content/user-guides/marathon.md @@ -93,7 +93,7 @@ There are two mitigation efforts: The Marathon health check makes sure that applications once deemed dysfunctional are being rescheduled to different slaves. However, they might take a while to get triggered and the follow-up processes to complete. -For that reason, the Treafik health check provides an additional check that responds more rapidly and does not require a configuration reload to happen. +For that reason, the Traefik health check provides an additional check that responds more rapidly and does not require a configuration reload to happen. Additionally, it protects from cases that the Marathon health check may not be able to cover, such as a network split. ### (Non-)Alternatives From ce851a59295f1e7d77706d9835423fd725827ce2 Mon Sep 17 00:00:00 2001 From: Tom Moulard Date: Mon, 21 Feb 2022 12:10:08 +0100 Subject: [PATCH 6/7] Fix struct tag typo --- .golangci.toml | 55 ++++++++++++++++++++++++++++++++++++++++++++ go.mod | 4 ++-- go.sum | 19 +++++++-------- pkg/types/metrics.go | 2 +- 4 files changed, 68 insertions(+), 12 deletions(-) diff --git a/.golangci.toml b/.golangci.toml index 73908f11c..ae9b717c8 100644 --- a/.golangci.toml +++ b/.golangci.toml @@ -50,6 +50,58 @@ kubeerror = "k8s.io/apimachinery/pkg/api/errors" composeapi = "github.com/docker/compose/v2/pkg/api" + [linters-settings.revive] + [[linters-settings.revive.rules]] + name = "struct-tag" + [[linters-settings.rules]] + name = "blank-imports" + [[linters-settings.rules]] + name = "context-as-argument" + [[linters-settings.rules]] + name = "context-keys-type" + [[linters-settings.rules]] + name = "dot-imports" + [[linters-settings.rules]] + name = "error-return" + [[linters-settings.rules]] + name = "error-strings" + [[linters-settings.rules]] + name = "error-naming" + [[linters-settings.rules]] + name = "exported" + [[linters-settings.rules]] + name = "if-return" + [[linters-settings.rules]] + name = "increment-decrement" + [[linters-settings.rules]] + name = "var-naming" + [[linters-settings.rules]] + name = "var-declaration" + [[linters-settings.rules]] + name = "package-comments" + [[linters-settings.rules]] + name = "range" + [[linters-settings.rules]] + name = "receiver-naming" + [[linters-settings.rules]] + name = "time-naming" + [[linters-settings.rules]] + name = "unexported-return" + [[linters-settings.rules]] + name = "indent-error-flow" + [[linters-settings.rules]] + name = "errorf" + [[linters-settings.rules]] + name = "empty-block" + [[linters-settings.rules]] + name = "superfluous-else" + [[linters-settings.rules]] + name = "unused-parameter" + [[linters-settings.rules]] + name = "unreachable-code" + [[linters-settings.rules]] + name = "redefines-builtin-id" + [linters-settings.gomoddirectives] replace-allow-list = [ "github.com/abbot/go-http-auth", @@ -159,3 +211,6 @@ [[issues.exclude-rules]] path = "pkg/log/deprecated.go" linters = ["godot"] + [[issues.exclude-rules]] + path = "(.+)\\.go" + text = "struct-tag: unknown option 'inline' in JSON tag" diff --git a/go.mod b/go.mod index 0a3120aba..720c8c58a 100644 --- a/go.mod +++ b/go.mod @@ -12,7 +12,7 @@ require ( github.com/aws/aws-sdk-go v1.39.0 github.com/cenkalti/backoff/v4 v4.1.1 github.com/compose-spec/compose-go v1.0.3 - github.com/containerd/containerd v1.5.8 // indirect + github.com/containerd/containerd v1.5.9 // indirect github.com/containous/alice v0.0.0-20181107144136-d83ebdd94cbd github.com/coreos/go-systemd v0.0.0-20191104093116-d3cd4ed1dbcf github.com/davecgh/go-spew v1.1.1 @@ -31,7 +31,7 @@ require ( github.com/google/go-github/v28 v28.1.1 github.com/gorilla/mux v1.8.0 github.com/gorilla/websocket v1.4.2 - github.com/hashicorp/consul v1.10.3 + github.com/hashicorp/consul v1.10.4 github.com/hashicorp/consul/api v1.12.0 github.com/hashicorp/go-hclog v0.16.1 github.com/hashicorp/go-multierror v1.1.1 diff --git a/go.sum b/go.sum index d056ed2bc..33f16ef30 100644 --- a/go.sum +++ b/go.sum @@ -207,8 +207,8 @@ github.com/armon/consul-api v0.0.0-20180202201655-eb2c6b5be1b6/go.mod h1:grANhF5 github.com/armon/go-metrics v0.0.0-20180917152333-f0300d1749da/go.mod h1:Q73ZrmVTwzkszR9V5SSuryQ31EELlFMUz1kKyl939pY= github.com/armon/go-metrics v0.0.0-20190430140413-ec5e00d3c878/go.mod h1:3AMJUQhVx52RsWOnlkpikZr01T/yAVN2gn0861vByNg= github.com/armon/go-metrics v0.3.0/go.mod h1:zXjbSimjXTd7vOpY8B0/2LpvNvDoXBuplAD+gJD3GYs= -github.com/armon/go-metrics v0.3.8 h1:oOxq3KPj0WhCuy50EhzwiyMyG2ovRQZpZLXQuOh2a/M= -github.com/armon/go-metrics v0.3.8/go.mod h1:4O98XIr/9W0sxpJ8UaYkvjk10Iff7SnFrb4QAOwNTFc= +github.com/armon/go-metrics v0.3.10 h1:FR+drcQStOe+32sYyJYyZ7FIdgoGGBnwLl+flodp8Uo= +github.com/armon/go-metrics v0.3.10/go.mod h1:4O98XIr/9W0sxpJ8UaYkvjk10Iff7SnFrb4QAOwNTFc= github.com/armon/go-radix v0.0.0-20180808171621-7fddfc383310/go.mod h1:ufUuZ+zHj4x4TnLV4JWEpy2hxWSpsRywHrMgIH9cCH8= github.com/armon/go-radix v1.0.0 h1:F4z6KzEeeQIMeLFa97iZU6vupzoecKdU5TX24SNppXI= github.com/armon/go-radix v1.0.0/go.mod h1:ufUuZ+zHj4x4TnLV4JWEpy2hxWSpsRywHrMgIH9cCH8= @@ -356,8 +356,8 @@ github.com/containerd/containerd v1.5.0-beta.4/go.mod h1:GmdgZd2zA2GYIBZ0w09Zvgq github.com/containerd/containerd v1.5.0-rc.0/go.mod h1:V/IXoMqNGgBlabz3tHD2TWDoTJseu1FGOKuoA4nNb2s= github.com/containerd/containerd v1.5.1/go.mod h1:0DOxVqwDy2iZvrZp2JUx/E+hS0UNTVn7dJnIOwtYR4g= github.com/containerd/containerd v1.5.5/go.mod h1:oSTh0QpT1w6jYcGmbiSbxv9OSQYaa88mPyWIuU79zyo= -github.com/containerd/containerd v1.5.8 h1:NmkCC1/QxyZFBny8JogwLpOy2f+VEbO/f6bV2Mqtwuw= -github.com/containerd/containerd v1.5.8/go.mod h1:YdFSv5bTFLpG2HIYmfqDpSYYTDX+mc5qtSuYx1YUb/s= +github.com/containerd/containerd v1.5.9 h1:rs6Xg1gtIxaeyG+Smsb/0xaSDu1VgFhOCKBXxMxbsF4= +github.com/containerd/containerd v1.5.9/go.mod h1:fvQqCfadDGga5HZyn3j4+dx56qj2I9YwBrlSdalvJYQ= github.com/containerd/continuity v0.0.0-20181203112020-004b46473808/go.mod h1:GL3xCUCBDV3CZiTSEKksMWbLE66hEyuu9qyDOOqM47Y= github.com/containerd/continuity v0.0.0-20190426062206-aaeac12a7ffc/go.mod h1:GL3xCUCBDV3CZiTSEKksMWbLE66hEyuu9qyDOOqM47Y= github.com/containerd/continuity v0.0.0-20190815185530-f2a389ac0a02/go.mod h1:GL3xCUCBDV3CZiTSEKksMWbLE66hEyuu9qyDOOqM47Y= @@ -866,8 +866,8 @@ github.com/hailocab/go-hostpool v0.0.0-20160125115350-e80d13ce29ed h1:5upAirOpQc github.com/hailocab/go-hostpool v0.0.0-20160125115350-e80d13ce29ed/go.mod h1:tMWxXQ9wFIaZeTI9F+hmhFiGpFmhOHzyShyFUhRm0H4= github.com/hanwen/go-fuse v1.0.0/go.mod h1:unqXarDXqzAk0rt98O2tVndEPIpUgLD9+rwFisZH3Ok= github.com/hanwen/go-fuse/v2 v2.0.4-0.20201208195215-4a458845028b/go.mod h1:0EQM6aH2ctVpvZ6a+onrQ/vaykxh2GH7hy3e13vzTUY= -github.com/hashicorp/consul v1.10.3 h1:I6CWR8+GCmwGXR0m2eRZasVdVUBwDiDoIjEjSxBCnwk= -github.com/hashicorp/consul v1.10.3/go.mod h1:EJMYpT39ZL2BnxjGRNTjfTH3s9893yd/DCX60PUnGUY= +github.com/hashicorp/consul v1.10.4 h1:rqKmYP49KnCSSxbiaJ4J2CnLA3zUAmI6KwASKxmPqFc= +github.com/hashicorp/consul v1.10.4/go.mod h1:3EJeqDz7W0LQJ2I4KzRtZZBgG5H80kZvgEtOLis/yCo= github.com/hashicorp/consul/api v1.1.0/go.mod h1:VmuI/Lkw1nC05EYQWNKwWGbkg+FbDBtguAZLlVdkD9Q= github.com/hashicorp/consul/api v1.3.0/go.mod h1:MmDNSzIMUjNpY/mQ398R4bk2FnqQLoPndWW5VkKPlCE= github.com/hashicorp/consul/api v1.10.0/go.mod h1:sDjTOq0yUyv5G4h+BqSea7Fn6BU+XbolEz1952UB+mk= @@ -955,8 +955,8 @@ github.com/hashicorp/memberlist v0.3.0/go.mod h1:MS2lj3INKhZjWNqd3N0m3J+Jxf3DAOn github.com/hashicorp/net-rpc-msgpackrpc v0.0.0-20151116020338-a14192a58a69/go.mod h1:/z+jUGRBlwVpUZfjute9jWaF6/HuhjuFQuL1YXzVD1Q= github.com/hashicorp/raft v1.1.1/go.mod h1:vPAJM8Asw6u8LxC3eJCUZmRP/E4QmUGE1R7g7k8sG/8= github.com/hashicorp/raft v1.2.0/go.mod h1:vPAJM8Asw6u8LxC3eJCUZmRP/E4QmUGE1R7g7k8sG/8= -github.com/hashicorp/raft v1.3.1 h1:zDT8ke8y2aP4wf9zPTB2uSIeavJ3Hx/ceY4jxI2JxuY= -github.com/hashicorp/raft v1.3.1/go.mod h1:4Ak7FSPnuvmb0GV6vgIAJ4vYT4bek9bb6Q+7HVbyzqM= +github.com/hashicorp/raft v1.3.2 h1:j2tqHqFnDdWCepLxzuo3b6WzS2krIweBrvEoqBbWMTo= +github.com/hashicorp/raft v1.3.2/go.mod h1:4Ak7FSPnuvmb0GV6vgIAJ4vYT4bek9bb6Q+7HVbyzqM= github.com/hashicorp/raft-autopilot v0.1.5 h1:onEfMH5uHVdXQqtas36zXUHEZxLdsJVu/nXHLcLdL1I= github.com/hashicorp/raft-autopilot v0.1.5/go.mod h1:Af4jZBwaNOI+tXfIqIdbcAnh/UyyqIMj/pOISIfhArw= github.com/hashicorp/raft-boltdb v0.0.0-20171010151810-6e5ba93211ea/go.mod h1:pNv7Wc3ycL6F5oOWn+tPGo2gWD4a5X+yp/ntwdKLjRk= @@ -1331,8 +1331,9 @@ github.com/opencontainers/go-digest v1.0.0-rc1.0.20180430190053-c9281466c8b2/go. github.com/opencontainers/go-digest v1.0.0 h1:apOUWs51W5PlhuyGyz9FCeeBIOUDA/6nW8Oi/yOhh5U= github.com/opencontainers/go-digest v1.0.0/go.mod h1:0JzlMkj0TRzQZfJkVvzbP0HBR3IKzErnv2BNG4W4MAM= github.com/opencontainers/image-spec v1.0.0/go.mod h1:BtxoFyWECRxE4U/7sNtV5W15zMzWCbyJoFRP3s7yZA0= -github.com/opencontainers/image-spec v1.0.1 h1:JMemWkRwHx4Zj+fVxWoMCFm/8sYGGrUVojFA6h/TRcI= github.com/opencontainers/image-spec v1.0.1/go.mod h1:BtxoFyWECRxE4U/7sNtV5W15zMzWCbyJoFRP3s7yZA0= +github.com/opencontainers/image-spec v1.0.2 h1:9yCKha/T5XdGtO0q9Q9a6T5NUCsTn/DrBg0D7ufOcFM= +github.com/opencontainers/image-spec v1.0.2/go.mod h1:BtxoFyWECRxE4U/7sNtV5W15zMzWCbyJoFRP3s7yZA0= github.com/opencontainers/runc v0.0.0-20190115041553-12f6a991201f/go.mod h1:qT5XzbpPznkRYVz/mWwUaVBUv2rmF59PVA73FjuZG0U= github.com/opencontainers/runc v0.1.1/go.mod h1:qT5XzbpPznkRYVz/mWwUaVBUv2rmF59PVA73FjuZG0U= github.com/opencontainers/runc v1.0.0-rc10/go.mod h1:qT5XzbpPznkRYVz/mWwUaVBUv2rmF59PVA73FjuZG0U= diff --git a/pkg/types/metrics.go b/pkg/types/metrics.go index 3b4c6463c..d557493c0 100644 --- a/pkg/types/metrics.go +++ b/pkg/types/metrics.go @@ -93,7 +93,7 @@ type InfluxDB struct { AddEntryPointsLabels bool `description:"Enable metrics on entry points." json:"addEntryPointsLabels,omitempty" toml:"addEntryPointsLabels,omitempty" yaml:"addEntryPointsLabels,omitempty" export:"true"` AddRoutersLabels bool `description:"Enable metrics on routers." json:"addRoutersLabels,omitempty" toml:"addRoutersLabels,omitempty" yaml:"addRoutersLabels,omitempty" export:"true"` AddServicesLabels bool `description:"Enable metrics on services." json:"addServicesLabels,omitempty" toml:"addServicesLabels,omitempty" yaml:"addServicesLabels,omitempty" export:"true"` - AdditionalLabels map[string]string `description:"Additional labels (influxdb tags) on all metrics" json:"additionalLabels,omitempty" toml:"additionalLabels,omitEmpty" yaml:"additionalLabels,omitEmpty" export:"true"` + AdditionalLabels map[string]string `description:"Additional labels (influxdb tags) on all metrics" json:"additionalLabels,omitempty" toml:"additionalLabels,omitempty" yaml:"additionalLabels,omitempty" export:"true"` } // SetDefaults sets the default values. From 819de021017bcc207911fb98c98f8c63252b487f Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 21 Feb 2022 06:40:09 -0500 Subject: [PATCH 7/7] Spelling --- CHANGELOG.md | 38 +++++++++---------- docs/content/user-guides/crd-acme/k3s.yml | 2 +- integration/websocket_test.go | 2 +- pkg/config/runtime/runtime_test.go | 6 +-- pkg/healthcheck/healthcheck.go | 2 +- pkg/metrics/prometheus.go | 6 +-- pkg/middlewares/recovery/recovery_test.go | 2 +- pkg/middlewares/retry/retry_test.go | 12 +++--- pkg/middlewares/tracing/wrapper.go | 10 ++--- pkg/provider/ecs/ecs.go | 6 +-- .../tcp/with_different_services_ns.yml | 2 +- .../udp/with_different_services_ns.yml | 2 +- .../gatewayclass_with_unknown_controller.yml | 2 +- .../gatewayclass_with_unknown_controller.yml | 2 +- .../gatewayclass_with_unknown_controller.yml | 2 +- pkg/server/service/loadbalancer/wrr/wrr.go | 2 +- pkg/tcp/chain_test.go | 2 +- .../src/components/_commons/ChartDoughnut.vue | 2 +- 18 files changed, 51 insertions(+), 51 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4c1c4d84d..048a60f76 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1783,7 +1783,7 @@ Same changelog as v2.0.3. - fix: remove extra backtick from routers docs ([#5572](https://github.com/traefik/traefik/pull/5572) by [serpi90](https://github.com/serpi90)) - document providersThrottleDuration ([#5519](https://github.com/traefik/traefik/pull/5519) by [mpl](https://github.com/mpl)) - Add a response forwarding section to the service documentation ([#5517](https://github.com/traefik/traefik/pull/5517) by [jbdoumenjou](https://github.com/jbdoumenjou)) -- Change instances of "dymanic" to "dynamic" ([#5504](https://github.com/traefik/traefik/pull/5504) by [dat-gitto-kid](https://github.com/dat-gitto-kid)) +- Change instances of "dynamic" to "dynamic" ([#5504](https://github.com/traefik/traefik/pull/5504) by [dat-gitto-kid](https://github.com/dat-gitto-kid)) - Add the pass host header section to the services documentation ([#5500](https://github.com/traefik/traefik/pull/5500) by [jbdoumenjou](https://github.com/jbdoumenjou)) - fix misspelling on documentation landing page ([#5613](https://github.com/traefik/traefik/pull/5613) by [cthompson527](https://github.com/cthompson527)) @@ -2775,7 +2775,7 @@ Same changelog as v2.0.3. - **[healthcheck]** Query params in health check ([#4188](https://github.com/traefik/traefik/pull/4188) by [mmatur](https://github.com/mmatur)) - **[metrics]** Upgraded DD APM library ([#4189](https://github.com/traefik/traefik/pull/4189) by [aantono](https://github.com/aantono)) - **[middleware]** Fix ssl force host secure middleware ([#4138](https://github.com/traefik/traefik/pull/4138) by [mmatur](https://github.com/mmatur)) -- **[oxy]** Fix unannonced trailers problem when body is empty ([#4258](https://github.com/traefik/traefik/pull/4258) by [juliens](https://github.com/juliens)) +- **[oxy]** Fix unannounced trailers problem when body is empty ([#4258](https://github.com/traefik/traefik/pull/4258) by [juliens](https://github.com/juliens)) - **[provider,server]** Log configuration errors from providers and keeps listening ([#4230](https://github.com/traefik/traefik/pull/4230) by [geraldcroes](https://github.com/geraldcroes)) - **[tls]** Implement Case-insensitive SNI matching ([#4132](https://github.com/traefik/traefik/pull/4132) by [dtomcej](https://github.com/dtomcej)) - Use ParseInt instead of Atoi for parsing durations ([#4263](https://github.com/traefik/traefik/pull/4263) by [mmatur](https://github.com/mmatur)) @@ -3919,7 +3919,7 @@ Same changelog as v2.0.3. - **[etcd]** Fix typo in examples ([#2446](https://github.com/traefik/traefik/pull/2446) by [dahefanteng](https://github.com/dahefanteng)) - **[k8s]** Add note to Kubernetes RBAC docs about RoleBindings and namespaces ([#2498](https://github.com/traefik/traefik/pull/2498) by [jmara](https://github.com/jmara)) - **[k8s]** k8s guide: Leave note about assumed DaemonSet usage. ([#2634](https://github.com/traefik/traefik/pull/2634) by [timoreimann](https://github.com/timoreimann)) -- **[k8s]** Apply various contentual and stylish improvements to the k8s docs. ([#2677](https://github.com/traefik/traefik/pull/2677) by [timoreimann](https://github.com/timoreimann)) +- **[k8s]** Apply various contextual and stylish improvements to the k8s docs. ([#2677](https://github.com/traefik/traefik/pull/2677) by [timoreimann](https://github.com/timoreimann)) - **[k8s]** Document rewrite-target annotation. ([#2676](https://github.com/traefik/traefik/pull/2676) by [timoreimann](https://github.com/timoreimann)) - **[k8s]** Remove obsolete links in k8s docs ([#2465](https://github.com/traefik/traefik/pull/2465) by [marco-jantke](https://github.com/marco-jantke)) - **[k8s]** Document filename parameter for Kubernetes. ([#2464](https://github.com/traefik/traefik/pull/2464) by [timoreimann](https://github.com/timoreimann)) @@ -3986,7 +3986,7 @@ Same changelog as v2.0.3. **Documentation:** - **[cluster]** Add a clustering example with Docker Swarm ([#2589](https://github.com/traefik/traefik/pull/2589) by [jmaitrehenry](https://github.com/jmaitrehenry)) -- **[k8s]** Apply various contentual and stylish improvements to the k8s docs. ([#2677](https://github.com/traefik/traefik/pull/2677) by [timoreimann](https://github.com/timoreimann)) +- **[k8s]** Apply various contextual and stylish improvements to the k8s docs. ([#2677](https://github.com/traefik/traefik/pull/2677) by [timoreimann](https://github.com/timoreimann)) - **[k8s]** Document rewrite-target annotation. ([#2676](https://github.com/traefik/traefik/pull/2676) by [timoreimann](https://github.com/timoreimann)) - **[provider,webui]** Fix redirect problem on dashboard + docs/tests on [web] ([#2686](https://github.com/traefik/traefik/pull/2686) by [Juliens](https://github.com/Juliens)) @@ -4696,7 +4696,7 @@ Same changelog as v2.0.3. [All Commits](https://github.com/traefik/traefik/compare/v1.3.7...v1.3.8) **Bug fixes:** -- **[middleware]** Compress and Webscocket ([#2079](https://github.com/traefik/traefik/pull/2079) by [ldez](https://github.com/ldez)) +- **[middleware]** Compress and Websocket ([#2079](https://github.com/traefik/traefik/pull/2079) by [ldez](https://github.com/ldez)) ## [v1.3.7](https://github.com/traefik/traefik/tree/v1.3.7) (2017-08-25) [All Commits](https://github.com/traefik/traefik/compare/v1.3.6...v1.3.7) @@ -4879,7 +4879,7 @@ Same changelog as v2.0.3. **Documentation:** - [#1578](https://github.com/traefik/traefik/issues/1578) Add Marathon guide. ([Stibbons](https://github.com/Stibbons)) -- [#1602](https://github.com/traefik/traefik/issues/1602) Re Orginise k8s docs to make 1.6 usage easier ([errm](https://github.com/errm)) +- [#1602](https://github.com/traefik/traefik/issues/1602) Re Organise k8s docs to make 1.6 usage easier ([errm](https://github.com/errm)) - [#1642](https://github.com/traefik/traefik/issues/1642) Update changelog ([ldez](https://github.com/ldez)) ## [v1.3.0-rc2](https://github.com/traefik/traefik/tree/v1.3.0-rc2) (2017-05-16) @@ -5032,7 +5032,7 @@ Same changelog as v2.0.3. - Bump go-rancher version [\#1219](https://github.com/traefik/traefik/pull/1219) ([SantoDE](https://github.com/SantoDE)) - Chunk taskArns into groups of 100 [\#1209](https://github.com/traefik/traefik/pull/1209) ([owen](https://github.com/owen)) - Prepare release v1.2.0 rc2 [\#1204](https://github.com/traefik/traefik/pull/1204) ([emilevauge](https://github.com/emilevauge)) -- Revert "Ensure that we don't add balancees with no health check runs … [\#1198](https://github.com/traefik/traefik/pull/1198) ([jangie](https://github.com/jangie)) +- Revert "Ensure that we don't add balances with no health check runs … [\#1198](https://github.com/traefik/traefik/pull/1198) ([jangie](https://github.com/jangie)) - Small fixes and improvements [\#1173](https://github.com/traefik/traefik/pull/1173) ([SantoDE](https://github.com/SantoDE)) - Fix docker issues with global and dead tasks [\#1167](https://github.com/traefik/traefik/pull/1167) ([christopherobin](https://github.com/christopherobin)) - Better ECS error checking [\#1143](https://github.com/traefik/traefik/pull/1143) ([lpetre](https://github.com/lpetre)) @@ -5058,7 +5058,7 @@ Same changelog as v2.0.3. - Add an ECS provider [\#1088](https://github.com/traefik/traefik/pull/1088) ([lpetre](https://github.com/lpetre)) - Update comment to reflect the code [\#1087](https://github.com/traefik/traefik/pull/1087) ([np](https://github.com/np)) - update NYTimes/gziphandler fixes \#1059 [\#1084](https://github.com/traefik/traefik/pull/1084) ([JamesKyburz](https://github.com/JamesKyburz)) -- Ensure that we don't add balancees with no health check runs if there is a health check defined on it [\#1080](https://github.com/traefik/traefik/pull/1080) ([jangie](https://github.com/jangie)) +- Ensure that we don't add balances with no health check runs if there is a health check defined on it [\#1080](https://github.com/traefik/traefik/pull/1080) ([jangie](https://github.com/jangie)) - Add FreeBSD & OpenBSD to crossbinary [\#1078](https://github.com/traefik/traefik/pull/1078) ([geoffgarside](https://github.com/geoffgarside)) - Fix metrics for multiple entry points [\#1071](https://github.com/traefik/traefik/pull/1071) ([matevzmihalic](https://github.com/matevzmihalic)) - Allow setting load balancer method and sticky using service annotations [\#1068](https://github.com/traefik/traefik/pull/1068) ([bakins](https://github.com/bakins)) @@ -5114,7 +5114,7 @@ Same changelog as v2.0.3. - Bind to specific ip address [\#1193](https://github.com/traefik/traefik/issues/1193) - DNS01 challenge use the wrong zone through route53 [\#1192](https://github.com/traefik/traefik/issues/1192) - Reverse proxy https to http backends fails [\#1180](https://github.com/traefik/traefik/issues/1180) -- Swarm Mode + Letsecrypt + KV Store [\#1176](https://github.com/traefik/traefik/issues/1176) +- Swarm Mode + Letsencrypt + KV Store [\#1176](https://github.com/traefik/traefik/issues/1176) - docker deploy -c example.yml e [\#1169](https://github.com/traefik/traefik/issues/1169) - Traefik not finding dynamically added services \(Docker Swarm Mode\) [\#1168](https://github.com/traefik/traefik/issues/1168) - Traefik with Kubernetes backend - keep getting 401 on all GET requests to kube-apiserver [\#1166](https://github.com/traefik/traefik/issues/1166) @@ -5132,7 +5132,7 @@ Same changelog as v2.0.3. **Merged pull requests:** -- Revert "Ensure that we don't add balancees with no health check runs … [\#1198](https://github.com/traefik/traefik/pull/1198) ([jangie](https://github.com/jangie)) +- Revert "Ensure that we don't add balances with no health check runs … [\#1198](https://github.com/traefik/traefik/pull/1198) ([jangie](https://github.com/jangie)) - Small fixes and improvements [\#1173](https://github.com/traefik/traefik/pull/1173) ([SantoDE](https://github.com/SantoDE)) - Fix docker issues with global and dead tasks [\#1167](https://github.com/traefik/traefik/pull/1167) ([christopherobin](https://github.com/christopherobin)) - Better ECS error checking [\#1143](https://github.com/traefik/traefik/pull/1143) ([lpetre](https://github.com/lpetre)) @@ -5203,7 +5203,7 @@ Same changelog as v2.0.3. - Add an ECS provider [\#1088](https://github.com/traefik/traefik/pull/1088) ([lpetre](https://github.com/lpetre)) - Update comment to reflect the code [\#1087](https://github.com/traefik/traefik/pull/1087) ([np](https://github.com/np)) - update NYTimes/gziphandler fixes \#1059 [\#1084](https://github.com/traefik/traefik/pull/1084) ([JamesKyburz](https://github.com/JamesKyburz)) -- Ensure that we don't add balancees with no health check runs if there is a health check defined on it [\#1080](https://github.com/traefik/traefik/pull/1080) ([jangie](https://github.com/jangie)) +- Ensure that we don't add balances with no health check runs if there is a health check defined on it [\#1080](https://github.com/traefik/traefik/pull/1080) ([jangie](https://github.com/jangie)) - Add FreeBSD & OpenBSD to crossbinary [\#1078](https://github.com/traefik/traefik/pull/1078) ([geoffgarside](https://github.com/geoffgarside)) - Fix metrics for multiple entry points [\#1071](https://github.com/traefik/traefik/pull/1071) ([matevzmihalic](https://github.com/matevzmihalic)) - Allow setting load balancer method and sticky using service annotations [\#1068](https://github.com/traefik/traefik/pull/1068) ([bakins](https://github.com/bakins)) @@ -5382,7 +5382,7 @@ Same changelog as v2.0.3. - Documented ProvidersThrottleDuration value is invalid [\#741](https://github.com/traefik/traefik/issues/741) - Sensible configuration for consulCatalog [\#737](https://github.com/traefik/traefik/issues/737) - Traefik ignoring container listening in more than one TCP port [\#734](https://github.com/traefik/traefik/issues/734) -- Loadbalaning issues with traefik and Docker Swarm cluster [\#730](https://github.com/traefik/traefik/issues/730) +- Loadbalancing issues with traefik and Docker Swarm cluster [\#730](https://github.com/traefik/traefik/issues/730) - issues with marathon app ids containing a dot [\#726](https://github.com/traefik/traefik/issues/726) - Error when using HA acme in kubernetes with etcd [\#725](https://github.com/traefik/traefik/issues/725) - \[Docker swarm mode\] No round robin when using service [\#718](https://github.com/traefik/traefik/issues/718) @@ -5421,7 +5421,7 @@ Same changelog as v2.0.3. - Update docs with new Mesos provider [\#548](https://github.com/traefik/traefik/issues/548) - Can I use Traefik without a domain name? [\#539](https://github.com/traefik/traefik/issues/539) - docker run syntax in swarm example has changed [\#528](https://github.com/traefik/traefik/issues/528) -- Priortities in 1.0.0 not behaving [\#506](https://github.com/traefik/traefik/issues/506) +- Priorities in 1.0.0 not behaving [\#506](https://github.com/traefik/traefik/issues/506) - Route by path [\#500](https://github.com/traefik/traefik/issues/500) - Secure WebSockets [\#467](https://github.com/traefik/traefik/issues/467) - Container IP Lost [\#375](https://github.com/traefik/traefik/issues/375) @@ -5479,7 +5479,7 @@ Same changelog as v2.0.3. - Update marathon [\#648](https://github.com/traefik/traefik/pull/648) ([emilevauge](https://github.com/emilevauge)) - Add backend features to docker [\#646](https://github.com/traefik/traefik/pull/646) ([jangie](https://github.com/jangie)) - enable consul catalog to use maxconn [\#645](https://github.com/traefik/traefik/pull/645) ([jangie](https://github.com/jangie)) -- Adopt the Code Of Coduct from http://contributor-covenant.org [\#641](https://github.com/traefik/traefik/pull/641) ([errm](https://github.com/errm)) +- Adopt the Code Of Conduct from http://contributor-covenant.org [\#641](https://github.com/traefik/traefik/pull/641) ([errm](https://github.com/errm)) - Use secure mode 600 instead of 644 for acme.json [\#639](https://github.com/traefik/traefik/pull/639) ([discordianfish](https://github.com/discordianfish)) - docker clarification, fix dead urls, misc typos [\#637](https://github.com/traefik/traefik/pull/637) ([djalal](https://github.com/djalal)) - add PING handler to dashboard API [\#630](https://github.com/traefik/traefik/pull/630) ([jangie](https://github.com/jangie)) @@ -5568,7 +5568,7 @@ Same changelog as v2.0.3. - dependencies installation error [\#755](https://github.com/traefik/traefik/issues/755) - k8s provider w/ acme? [\#752](https://github.com/traefik/traefik/issues/752) - Documented ProvidersThrottleDuration value is invalid [\#741](https://github.com/traefik/traefik/issues/741) -- Loadbalaning issues with traefik and Docker Swarm cluster [\#730](https://github.com/traefik/traefik/issues/730) +- Loadbalancing issues with traefik and Docker Swarm cluster [\#730](https://github.com/traefik/traefik/issues/730) - issues with marathon app ids containing a dot [\#726](https://github.com/traefik/traefik/issues/726) - How Routing traffic depending on path not domain in docker [\#706](https://github.com/traefik/traefik/issues/706) - Traefik crashes when using Consul catalog [\#699](https://github.com/traefik/traefik/issues/699) @@ -5677,7 +5677,7 @@ Same changelog as v2.0.3. - Traefik stuck when used as frontend for a streaming API [\#560](https://github.com/traefik/traefik/issues/560) - Exclude some frontends in consul catalog [\#555](https://github.com/traefik/traefik/issues/555) - Can I use Traefik without a domain name? [\#539](https://github.com/traefik/traefik/issues/539) -- Priortities in 1.0.0 not behaving [\#506](https://github.com/traefik/traefik/issues/506) +- Priorities in 1.0.0 not behaving [\#506](https://github.com/traefik/traefik/issues/506) - Route by path [\#500](https://github.com/traefik/traefik/issues/500) - Container IP Lost [\#375](https://github.com/traefik/traefik/issues/375) @@ -5702,7 +5702,7 @@ Same changelog as v2.0.3. - Update marathon [\#648](https://github.com/traefik/traefik/pull/648) ([emilevauge](https://github.com/emilevauge)) - Add backend features to docker [\#646](https://github.com/traefik/traefik/pull/646) ([jangie](https://github.com/jangie)) - enable consul catalog to use maxconn [\#645](https://github.com/traefik/traefik/pull/645) ([jangie](https://github.com/jangie)) -- Adopt the Code Of Coduct from http://contributor-covenant.org [\#641](https://github.com/traefik/traefik/pull/641) ([errm](https://github.com/errm)) +- Adopt the Code Of Conduct from http://contributor-covenant.org [\#641](https://github.com/traefik/traefik/pull/641) ([errm](https://github.com/errm)) - Use secure mode 600 instead of 644 for acme.json [\#639](https://github.com/traefik/traefik/pull/639) ([discordianfish](https://github.com/discordianfish)) - docker clarification, fix dead urls, misc typos [\#637](https://github.com/traefik/traefik/pull/637) ([djalal](https://github.com/djalal)) - add PING handler to dashboard API [\#630](https://github.com/traefik/traefik/pull/630) ([jangie](https://github.com/jangie)) @@ -5778,7 +5778,7 @@ Same changelog as v2.0.3. **Closed issues:** - Can I use Traefik without a domain name? [\#539](https://github.com/traefik/traefik/issues/539) -- Priortities in 1.0.0 not behaving [\#506](https://github.com/traefik/traefik/issues/506) +- Priorities in 1.0.0 not behaving [\#506](https://github.com/traefik/traefik/issues/506) - Route by path [\#500](https://github.com/traefik/traefik/issues/500) **Merged pull requests:** @@ -5878,7 +5878,7 @@ Same changelog as v2.0.3. - Traefik doesn't listen on IPv4 ports [\#434](https://github.com/traefik/traefik/issues/434) - Not listening on port 80 [\#432](https://github.com/traefik/traefik/issues/432) - docs need updating for new frontend rules format [\#423](https://github.com/traefik/traefik/issues/423) -- Does traefik supports for Mac? \(For devlelopment\) [\#417](https://github.com/traefik/traefik/issues/417) +- Does traefik supports for Mac? \(For development\) [\#417](https://github.com/traefik/traefik/issues/417) **Merged pull requests:** diff --git a/docs/content/user-guides/crd-acme/k3s.yml b/docs/content/user-guides/crd-acme/k3s.yml index 897a985df..53c79b1fd 100644 --- a/docs/content/user-guides/crd-acme/k3s.yml +++ b/docs/content/user-guides/crd-acme/k3s.yml @@ -27,4 +27,4 @@ node: volumes: # this is where you would place a alternative traefik image (saved as a .tar file with # 'docker save'), if you want to use it, instead of the traefik:v2.6 image. - - /sowewhere/on/your/host/custom-image:/var/lib/rancher/k3s/agent/images + - /somewhere/on/your/host/custom-image:/var/lib/rancher/k3s/agent/images diff --git a/integration/websocket_test.go b/integration/websocket_test.go index 819da7cc1..33425624f 100644 --- a/integration/websocket_test.go +++ b/integration/websocket_test.go @@ -500,7 +500,7 @@ func (s *WebsocketSuite) TestSSLhttp2(c *check.C) { c.Assert(string(msg), checker.Equals, "OK") } -func (s *WebsocketSuite) TestHeaderAreForwared(c *check.C) { +func (s *WebsocketSuite) TestHeaderAreForwarded(c *check.C) { upgrader := gorillawebsocket.Upgrader{} // use default options srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { diff --git a/pkg/config/runtime/runtime_test.go b/pkg/config/runtime/runtime_test.go index 5ecb8864d..3a7588be3 100644 --- a/pkg/config/runtime/runtime_test.go +++ b/pkg/config/runtime/runtime_test.go @@ -144,7 +144,7 @@ func TestPopulateUsedBy(t *testing.T) { }, }, { - desc: "2 different Services each used by a disctinct router.", + desc: "2 different Services each used by a distinct router.", conf: &runtime.Configuration{ Services: map[string]*runtime.ServiceInfo{ "foo-service@myprovider": { @@ -384,7 +384,7 @@ func TestPopulateUsedBy(t *testing.T) { }, }, { - desc: "2 middlewares from 2 disctinct providers both used by 2 Routers", + desc: "2 middlewares from 2 distinct providers both used by 2 Routers", conf: &runtime.Configuration{ Services: map[string]*runtime.ServiceInfo{ "foo-service@myprovider": { @@ -593,7 +593,7 @@ func TestPopulateUsedBy(t *testing.T) { }, }, { - desc: "TCP, 2 different Services each used by a disctinct router.", + desc: "TCP, 2 different Services each used by a distinct router.", conf: &runtime.Configuration{ TCPServices: map[string]*runtime.TCPServiceInfo{ "foo-service@myprovider": { diff --git a/pkg/healthcheck/healthcheck.go b/pkg/healthcheck/healthcheck.go index fd633f713..000ee2d00 100644 --- a/pkg/healthcheck/healthcheck.go +++ b/pkg/healthcheck/healthcheck.go @@ -44,7 +44,7 @@ type BalancerHandler interface { } // BalancerStatusHandler is an http Handler that does load-balancing, -// andupdates its parents of its status. +// and updates its parents of its status. type BalancerStatusHandler interface { BalancerHandler StatusUpdater diff --git a/pkg/metrics/prometheus.go b/pkg/metrics/prometheus.go index c4cf782df..cad446179 100644 --- a/pkg/metrics/prometheus.go +++ b/pkg/metrics/prometheus.go @@ -131,7 +131,7 @@ func initStandardRegistry(config *types.Prometheus) Registry { Name: configLastReloadFailureName, Help: "Last config reload failure", }, []string{}) - tlsCertsNotAfterTimesptamp := newGaugeFrom(promState.collectors, stdprometheus.GaugeOpts{ + tlsCertsNotAfterTimestamp := newGaugeFrom(promState.collectors, stdprometheus.GaugeOpts{ Name: tlsCertsNotAfterTimestamp, Help: "Certificate expiration timestamp", }, []string{"cn", "serial", "sans"}) @@ -141,7 +141,7 @@ func initStandardRegistry(config *types.Prometheus) Registry { configReloadsFailures.cv.Describe, lastConfigReloadSuccess.gv.Describe, lastConfigReloadFailure.gv.Describe, - tlsCertsNotAfterTimesptamp.gv.Describe, + tlsCertsNotAfterTimestamp.gv.Describe, } reg := &standardRegistry{ @@ -152,7 +152,7 @@ func initStandardRegistry(config *types.Prometheus) Registry { configReloadsFailureCounter: configReloadsFailures, lastConfigReloadSuccessGauge: lastConfigReloadSuccess, lastConfigReloadFailureGauge: lastConfigReloadFailure, - tlsCertsNotAfterTimestampGauge: tlsCertsNotAfterTimesptamp, + tlsCertsNotAfterTimestampGauge: tlsCertsNotAfterTimestamp, } if config.AddEntryPointsLabels { diff --git a/pkg/middlewares/recovery/recovery_test.go b/pkg/middlewares/recovery/recovery_test.go index 162a9734f..570717ebc 100644 --- a/pkg/middlewares/recovery/recovery_test.go +++ b/pkg/middlewares/recovery/recovery_test.go @@ -12,7 +12,7 @@ import ( func TestRecoverHandler(t *testing.T) { fn := func(w http.ResponseWriter, r *http.Request) { - panic("I love panicing!") + panic("I love panicking!") } recovery, err := New(context.Background(), http.HandlerFunc(fn)) require.NoError(t, err) diff --git a/pkg/middlewares/retry/retry_test.go b/pkg/middlewares/retry/retry_test.go index c0a967f7d..8d629ebdf 100644 --- a/pkg/middlewares/retry/retry_test.go +++ b/pkg/middlewares/retry/retry_test.go @@ -104,11 +104,11 @@ func TestRetry(t *testing.T) { t.Run(test.desc, func(t *testing.T) { t.Parallel() - retryAttemps := 0 + retryAttempts := 0 next := http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) { - retryAttemps++ + retryAttempts++ - if retryAttemps > test.amountFaultyEndpoints { + if retryAttempts > test.amountFaultyEndpoints { // calls WroteHeaders on httptrace. _ = r.Write(io.Discard) @@ -275,11 +275,11 @@ func TestRetryWebsocket(t *testing.T) { t.Run(test.desc, func(t *testing.T) { t.Parallel() - retryAttemps := 0 + retryAttempts := 0 next := http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) { - retryAttemps++ + retryAttempts++ - if retryAttemps > test.amountFaultyEndpoints { + if retryAttempts > test.amountFaultyEndpoints { upgrader := websocket.Upgrader{} _, err := upgrader.Upgrade(rw, r, nil) if err != nil { diff --git a/pkg/middlewares/tracing/wrapper.go b/pkg/middlewares/tracing/wrapper.go index 86efd52e6..9386bd14e 100644 --- a/pkg/middlewares/tracing/wrapper.go +++ b/pkg/middlewares/tracing/wrapper.go @@ -10,12 +10,12 @@ import ( "github.com/traefik/traefik/v2/pkg/tracing" ) -// Tracable embeds tracing information. -type Tracable interface { +// Traceable embeds tracing information. +type Traceable interface { GetTracingInformation() (name string, spanKind ext.SpanKindEnum) } -// Wrap adds tracability to an alice.Constructor. +// Wrap adds traceability to an alice.Constructor. func Wrap(ctx context.Context, constructor alice.Constructor) alice.Constructor { return func(next http.Handler) (http.Handler, error) { if constructor == nil { @@ -26,8 +26,8 @@ func Wrap(ctx context.Context, constructor alice.Constructor) alice.Constructor return nil, err } - if tracableHandler, ok := handler.(Tracable); ok { - name, spanKind := tracableHandler.GetTracingInformation() + if traceableHandler, ok := handler.(Traceable); ok { + name, spanKind := traceableHandler.GetTracingInformation() log.FromContext(ctx).WithField(log.MiddlewareName, name).Debug("Adding tracing to middleware") return NewWrapper(handler, name, spanKind), nil } diff --git a/pkg/provider/ecs/ecs.go b/pkg/provider/ecs/ecs.go index e2711bc9e..907a6a88a 100644 --- a/pkg/provider/ecs/ecs.go +++ b/pkg/provider/ecs/ecs.go @@ -454,7 +454,7 @@ func (p *Provider) lookupTaskDefinitions(ctx context.Context, client *awsClient, // chunkIDs ECS expects no more than 100 parameters be passed to a API call; // thus, pack each string into an array capped at 100 elements. func (p *Provider) chunkIDs(ids []*string) [][]*string { - var chuncked [][]*string + var chunked [][]*string for i := 0; i < len(ids); i += 100 { var sliceEnd int if i+100 < len(ids) { @@ -462,7 +462,7 @@ func (p *Provider) chunkIDs(ids []*string) [][]*string { } else { sliceEnd = len(ids) } - chuncked = append(chuncked, ids[i:sliceEnd]) + chunked = append(chunked, ids[i:sliceEnd]) } - return chuncked + return chunked } diff --git a/pkg/provider/kubernetes/crd/fixtures/tcp/with_different_services_ns.yml b/pkg/provider/kubernetes/crd/fixtures/tcp/with_different_services_ns.yml index 4d89d1184..02af98254 100644 --- a/pkg/provider/kubernetes/crd/fixtures/tcp/with_different_services_ns.yml +++ b/pkg/provider/kubernetes/crd/fixtures/tcp/with_different_services_ns.yml @@ -27,5 +27,5 @@ spec: weight: 4 # with unknown namespace - name: whoamitcp - namespace: unknwonns + namespace: unknowns port: 8080 diff --git a/pkg/provider/kubernetes/crd/fixtures/udp/with_different_services_ns.yml b/pkg/provider/kubernetes/crd/fixtures/udp/with_different_services_ns.yml index 2943a9238..d5c6cc728 100644 --- a/pkg/provider/kubernetes/crd/fixtures/udp/with_different_services_ns.yml +++ b/pkg/provider/kubernetes/crd/fixtures/udp/with_different_services_ns.yml @@ -26,5 +26,5 @@ spec: weight: 4 # with unknown namespace - name: whoamiudp - namespace: unknwonns + namespace: unknowns port: 8080 diff --git a/pkg/provider/kubernetes/gateway/fixtures/httproute/gatewayclass_with_unknown_controller.yml b/pkg/provider/kubernetes/gateway/fixtures/httproute/gatewayclass_with_unknown_controller.yml index b7982b94d..f4962f2b3 100644 --- a/pkg/provider/kubernetes/gateway/fixtures/httproute/gatewayclass_with_unknown_controller.yml +++ b/pkg/provider/kubernetes/gateway/fixtures/httproute/gatewayclass_with_unknown_controller.yml @@ -4,7 +4,7 @@ apiVersion: gateway.networking.k8s.io/v1alpha2 metadata: name: my-gateway-class spec: - controllerName: unkown.io/gateway-controller + controllerName: unknown.io/gateway-controller --- kind: Gateway diff --git a/pkg/provider/kubernetes/gateway/fixtures/tcproute/gatewayclass_with_unknown_controller.yml b/pkg/provider/kubernetes/gateway/fixtures/tcproute/gatewayclass_with_unknown_controller.yml index e7bf59d20..5dafcdfd3 100644 --- a/pkg/provider/kubernetes/gateway/fixtures/tcproute/gatewayclass_with_unknown_controller.yml +++ b/pkg/provider/kubernetes/gateway/fixtures/tcproute/gatewayclass_with_unknown_controller.yml @@ -4,7 +4,7 @@ apiVersion: gateway.networking.k8s.io/v1alpha2 metadata: name: my-gateway-class spec: - controllerName: unkown.io/gateway-controller + controllerName: unknown.io/gateway-controller --- kind: Gateway diff --git a/pkg/provider/kubernetes/gateway/fixtures/tlsroute/gatewayclass_with_unknown_controller.yml b/pkg/provider/kubernetes/gateway/fixtures/tlsroute/gatewayclass_with_unknown_controller.yml index 76fa7680f..6b19420b0 100644 --- a/pkg/provider/kubernetes/gateway/fixtures/tlsroute/gatewayclass_with_unknown_controller.yml +++ b/pkg/provider/kubernetes/gateway/fixtures/tlsroute/gatewayclass_with_unknown_controller.yml @@ -15,7 +15,7 @@ apiVersion: gateway.networking.k8s.io/v1alpha2 metadata: name: my-gateway-class spec: - controllerName: unkown.io/gateway-controller + controllerName: unknown.io/gateway-controller --- kind: Gateway diff --git a/pkg/server/service/loadbalancer/wrr/wrr.go b/pkg/server/service/loadbalancer/wrr/wrr.go index c9fc0c7e4..a1fa085aa 100644 --- a/pkg/server/service/loadbalancer/wrr/wrr.go +++ b/pkg/server/service/loadbalancer/wrr/wrr.go @@ -86,7 +86,7 @@ func (b *Balancer) Push(x interface{}) { b.handlers = append(b.handlers, h) } -// Pop implements heap.Interface for poping an item from the heap. +// Pop implements heap.Interface for popping an item from the heap. // It panics if b.Len() < 1. func (b *Balancer) Pop() interface{} { h := b.handlers[len(b.handlers)-1] diff --git a/pkg/tcp/chain_test.go b/pkg/tcp/chain_test.go index 3460d9d7d..ef51fa539 100644 --- a/pkg/tcp/chain_test.go +++ b/pkg/tcp/chain_test.go @@ -144,7 +144,7 @@ func TestAppendRespectsImmutability(t *testing.T) { newChain := chain.Append(tagMiddleware("")) if &chain.constructors[0] == &newChain.constructors[0] { - t.Error("Apppend does not respect immutability") + t.Error("Append does not respect immutability") } } diff --git a/webui/src/components/_commons/ChartDoughnut.vue b/webui/src/components/_commons/ChartDoughnut.vue index a8993154e..3806ae85a 100644 --- a/webui/src/components/_commons/ChartDoughnut.vue +++ b/webui/src/components/_commons/ChartDoughnut.vue @@ -16,7 +16,7 @@ export default { }, watch: { chartdata: function (newData, oldData) { - // TODO - bug, 'update()' not update the chart, remplace for renderChart() + // TODO - bug, 'update()' not update the chart, replace for renderChart() // console.log('new data from watcher...', newData, oldData, isEqual(newData.datasets[0].data, oldData.datasets[0].data)) if (!isEqual(newData.datasets[0].data, oldData.datasets[0].data)) { // this.$data._chart.update()