baalajimaestro/NewPipe
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases 5 Wiki Activity

Fixes #9518

Browse source 
- Crash fix on clicking on add to playlist.
- Added toast when clicked on share button for better UI.
This commit is contained in:
pratyaksh1610 2022-12-09 14:09:40 +05:30
parent 4a27d371e0
commit c537776826
2 changed files with 19 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
app/src/main/java/org/schabi/newpipe/fragments/list/playlist/PlaylistFragment.java
View file

@ -13,6 +13,7 @@ import android.view.MenuInflater;
import android.view.MenuItem; import android.view.MenuItem;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import android.widget.Toast;
import androidx.annotation.NonNull; import androidx.annotation.NonNull;
import androidx.annotation.Nullable; import androidx.annotation.Nullable;
@ -233,21 +234,29 @@ public class PlaylistFragment extends BaseListInfoFragment<StreamInfoItem, Playl
if (currentInfo != null) { if (currentInfo != null) {
ShareUtils.shareText(requireContext(), name, url, ShareUtils.shareText(requireContext(), name, url,
currentInfo.getThumbnailUrl()); currentInfo.getThumbnailUrl());
} else {
Toast.makeText(getContext(), getString(R.string.playlist_loading_message),
Toast.LENGTH_SHORT).show();
} }
break; break;
case R.id.menu_item_bookmark: case R.id.menu_item_bookmark:
onBookmarkClicked(); onBookmarkClicked();
break; break;
case R.id.menu_item_append_playlist: case R.id.menu_item_append_playlist:
disposables.add(PlaylistDialog.createCorrespondingDialog( if (currentInfo != null) {
getContext(), disposables.add(PlaylistDialog.createCorrespondingDialog(
getPlayQueue() getContext(),
.getStreams() getPlayQueue()
.stream() .getStreams()
.map(StreamEntity::new) .stream()
.collect(Collectors.toList()), .map(StreamEntity::new)
dialog -> dialog.show(getFM(), TAG) .collect(Collectors.toList()),
)); dialog -> dialog.show(getFM(), TAG)
));
} else {
Toast.makeText(getContext(), getString(R.string.playlist_loading_message),
Toast.LENGTH_SHORT).show();
}
break; break;
default: default:
return super.onOptionsItemSelected(item); return super.onOptionsItemSelected(item);

1
app/src/main/res/values/strings.xml
View file

@ -241,6 +241,7 @@
<string name="restore_defaults">Restore defaults</string> <string name="restore_defaults">Restore defaults</string>
<string name="restore_defaults_confirmation">Do you want to restore defaults?</string> <string name="restore_defaults_confirmation">Do you want to restore defaults?</string>
<string name="permission_display_over_apps">Give permission to display over other apps</string> <string name="permission_display_over_apps">Give permission to display over other apps</string>
<string name="playlist_loading_message">Playlist loading…</string>
<!-- error activity --> <!-- error activity -->
<string name="error_report_notification_title">NewPipe encountered an error, tap to report</string> <string name="error_report_notification_title">NewPipe encountered an error, tap to report</string>
<string name="error_report_notification_toast">An error occurred, see the notification</string> <string name="error_report_notification_toast">An error occurred, see the notification</string>