baalajimaestro/NewPipe
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases 3 Wiki Activity

Merge pull request #10435 from TeamNewPipe/imp/codequality

Browse source 
Improve codequality
This commit is contained in:
Stypox 2023-09-20 21:24:44 +02:00 committed by GitHub
parent 673aa0a87b 0acc3532c9
commit b798ff5c92
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 23 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/java/org/schabi/newpipe/fragments/list/search/SearchFragment.java
View file

@ -167,6 +167,10 @@ public class SearchFragment extends BaseListFragment<SearchInfo, ListExtractor.I
/*////////////////////////////////////////////////////////////////////////*/
/**
* TextWatcher to remove rich-text formatting on the search EditText when pasting content
* from the clipboard.
*/
private TextWatcher textWatcher;
public static SearchFragment getInstance(final int serviceId, final String searchString) {
@ -583,11 +587,13 @@ public class SearchFragment extends BaseListFragment<SearchInfo, ListExtractor.I
@Override
public void beforeTextChanged(final CharSequence s, final int start,
final int count, final int after) {
// Do nothing, old text is already clean
}
@Override
public void onTextChanged(final CharSequence s, final int start,
final int before, final int count) {
// Changes are handled in afterTextChanged; CharSequence cannot be changed here.
}
@Override

5
app/src/main/java/org/schabi/newpipe/local/bookmark/BookmarkFragment.java
View file

@ -91,11 +91,6 @@ public final class BookmarkFragment extends BaseLocalListFragment<List<PlaylistL
// Fragment LifeCycle - Views
///////////////////////////////////////////////////////////////////////////
@Override
protected void initViews(final View rootView, final Bundle savedInstanceState) {
super.initViews(rootView, savedInstanceState);
}
@Override
protected void initListeners() {
super.initListeners();

8
app/src/main/java/org/schabi/newpipe/player/playqueue/SinglePlayQueue.java
View file

@ -1,5 +1,7 @@
package org.schabi.newpipe.player.playqueue;
import androidx.annotation.NonNull;
import org.schabi.newpipe.extractor.stream.StreamInfo;
import org.schabi.newpipe.extractor.stream.StreamInfoItem;
@ -20,11 +22,11 @@ public final class SinglePlayQueue extends PlayQueue {
getItem().setRecoveryPosition(startPosition);
}
public SinglePlayQueue(final List<StreamInfoItem> items, final int index) {
public SinglePlayQueue(@NonNull final List<StreamInfoItem> items, final int index) {
super(index, playQueueItemsOf(items));
}
private static List<PlayQueueItem> playQueueItemsOf(final List<StreamInfoItem> items) {
private static List<PlayQueueItem> playQueueItemsOf(@NonNull final List<StreamInfoItem> items) {
final List<PlayQueueItem> playQueueItems = new ArrayList<>(items.size());
for (final StreamInfoItem item : items) {
playQueueItems.add(new PlayQueueItem(item));
@ -39,5 +41,7 @@ public final class SinglePlayQueue extends PlayQueue {
@Override
public void fetch() {
// Item was already passed in constructor.
// No further items need to be fetched as this is a PlayQueue with only one item
}
}

8
app/src/main/java/us/shandian/giga/get/DownloadInitializer.java
View file

@ -18,10 +18,10 @@ import static org.schabi.newpipe.BuildConfig.DEBUG;
import static us.shandian.giga.get.DownloadMission.ERROR_HTTP_FORBIDDEN;
public class DownloadInitializer extends Thread {
private final static String TAG = "DownloadInitializer";
final static int mId = 0;
private final static int RESERVE_SPACE_DEFAULT = 5 * 1024 * 1024;// 5 MiB
private final static int RESERVE_SPACE_MAXIMUM = 150 * 1024 * 1024;// 150 MiB
private static final String TAG = "DownloadInitializer";
static final int mId = 0;
private static final int RESERVE_SPACE_DEFAULT = 5 * 1024 * 1024;// 5 MiB
private static final int RESERVE_SPACE_MAXIMUM = 150 * 1024 * 1024;// 150 MiB
private final DownloadMission mMission;
private HttpURLConnection mConn;

8
app/src/main/java/us/shandian/giga/io/CircularFileWriter.java
View file

@ -11,10 +11,10 @@ import java.util.Objects;
public class CircularFileWriter extends SharpStream {
private final static int QUEUE_BUFFER_SIZE = 8 * 1024;// 8 KiB
private final static int COPY_BUFFER_SIZE = 128 * 1024; // 128 KiB
private final static int NOTIFY_BYTES_INTERVAL = 64 * 1024;// 64 KiB
private final static int THRESHOLD_AUX_LENGTH = 15 * 1024 * 1024;// 15 MiB
private static final int QUEUE_BUFFER_SIZE = 8 * 1024;// 8 KiB
private static final int COPY_BUFFER_SIZE = 128 * 1024; // 128 KiB
private static final int NOTIFY_BYTES_INTERVAL = 64 * 1024;// 64 KiB
private static final int THRESHOLD_AUX_LENGTH = 15 * 1024 * 1024;// 15 MiB
private final OffsetChecker callback;

6
app/src/main/java/us/shandian/giga/service/DownloadManager.java
View file

@ -30,9 +30,9 @@ public class DownloadManager {
enum NetworkState {Unavailable, Operating, MeteredOperating}
public final static int SPECIAL_NOTHING = 0;
public final static int SPECIAL_PENDING = 1;
public final static int SPECIAL_FINISHED = 2;
public static final int SPECIAL_NOTHING = 0;
public static final int SPECIAL_PENDING = 1;
public static final int SPECIAL_FINISHED = 2;
public static final String TAG_AUDIO = "audio";
public static final String TAG_VIDEO = "video";